Fix error handling in least and greatest Presto functions (#3818)

Summary:
Report errors via EvalCtx::setError instead of throwing.

Fixes #3794

Pull Request resolved: #3818

Reviewed By: mbasmanova

Differential Revision: D42756552

Pulled By: kgpai

fbshipit-source-id: ad7bbe2653a60ed6180dd6dcba43251d205f61a1

velox/functions/prestosql/GreatestLeast.cpp

@@ -76,7 +76,7 @@ class ExtremeValueFunction : public exec::VectorFunction {
     exec::DecodedArgs decodedArgs(rows, args, context);
 
     std::set<size_t> usedInputs;
-    rows.applyToSelected([&](int row) {
+    context.applyToSelectedNoThrow(rows, [&](int row) {
       size_t valueIndex = 0;
 
       T currentValue = decodedArgs.at(0)->valueAt<T>(row);

velox/functions/prestosql/tests/GreatestLeastTest.cpp

@@ -25,7 +25,7 @@ class GreatestLeastTest : public functions::test::FunctionBaseTest {
   void runTest(
       const std::string& query,
       const std::vector<std::vector<T>>& inputs,
-      const std::vector<T>& output,
+      const std::vector<std::optional<T>>& output,
       std::optional<size_t> stringBuffersExpectedCount = std::nullopt) {
     // Create input vectors
     auto vectorSize = inputs[0].size();
@@ -40,7 +40,11 @@ class GreatestLeastTest : public functions::test::FunctionBaseTest {
     // Call evaluate to run the query on the created input
     auto result = evaluate<SimpleVector<T>>(query, makeRowVector(inputColumns));
     for (int32_t i = 0; i < vectorSize; ++i) {
-      ASSERT_EQ(result->valueAt(i), output[i]);
+      if (output[i].has_value()) {
+        ASSERT_EQ(result->valueAt(i), output[i]);
+      } else {
+        ASSERT_TRUE(result->isNullAt(i));
+      }
     }
 
     if (stringBuffersExpectedCount.has_value()) {
@@ -59,15 +63,18 @@ TEST_F(GreatestLeastTest, leastDouble) {
 }
 
 TEST_F(GreatestLeastTest, nanInput) {
+  std::vector<double> input{0, 1.1, std::nan("1")};
   assertUserInvalidArgument(
       [&]() { runTest<double>("least(c0)", {{0.0 / 0.0}}, {0}); },
       "Invalid argument to least(): NaN");
+  runTest<double>("try(least(c0, 1.0))", {input}, {0, 1.0, std::nullopt});
 
   assertUserInvalidArgument(
       [&]() {
         runTest<double>("greatest(c0)", {1, {0.0 / 0.0}}, {1, 0});
       },
       "Invalid argument to greatest(): NaN");
+  runTest<double>("try(greatest(c0, 1.0))", {input}, {1.0, 1.1, std::nullopt});
 }
 
 TEST_F(GreatestLeastTest, greatestDouble) {