Skip to content

Commit

Permalink
fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
majetideepak committed Sep 4, 2024
1 parent 64eebce commit 0a9bf83
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ if(DEFINED ENV{CONDA_PREFIX})
endif()

if(DEFINED ENV{INSTALL_PREFIX})
message(STATUS "Install directory set to: $ENV{INSTALL_PREFIX}")
message(STATUS "Dependency install directory set to: $ENV{INSTALL_PREFIX}")
list(APPEND CMAKE_PREFIX_PATH "$ENV{INSTALL_PREFIX}")
endif()

Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,16 @@ dependencies for a given platform.
The following setup scripts use the `DEPENDENCY_DIR` environment variable to set the
location to download and build packages. This defaults to `deps-download` in the current
working directory. Use `INSTALL_PREFIX` to set the install directory of the packages.
This defaults to `deps-install` in the current working directory on MacOS and to the
This defaults to `deps-install` in the current working directory on macOS and to the
default install location on linux.

For MacOS, you will have to manually add the INSTALL_PREFIX value say
For macOS, you will have to manually add the INSTALL_PREFIX value say
`export INSTALL_PREFIX=/Users/$USERNAME/velox/deps-install` to `~/.zshrc` so that
subsequent builds can pick it up.

### Setting up on macOS

On a MacOS machine (either Intel or Apple silicon) you can setup and then build like so:
On a macOS machine (either Intel or Apple silicon) you can setup and then build like so:

```shell
$ ./scripts/setup-macos.sh
Expand Down Expand Up @@ -137,7 +137,7 @@ $ ./scripts/setup-adapters.sh
$ make
```

Note that `setup-adapters.sh` supports MacOS and Ubuntu 20.04 or later.
Note that `setup-adapters.sh` supports macOS and Ubuntu 20.04 or later.

### Using Clang on Linux

Expand Down
1 change: 1 addition & 0 deletions scripts/setup-macos.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ SCRIPTDIR=$(dirname "${BASH_SOURCE[0]}")
export INSTALL_PREFIX=${INSTALL_PREFIX:-"$(pwd)/deps-install"}
source $SCRIPTDIR/setup-helper-functions.sh
PYTHON_VENV=${PYHTON_VENV:-"${SCRIPTDIR}/../.venv"}
# Allow installed package headers to be picked up before brew package headers
export OS_CXXFLAGS=" -isystem $(brew --prefix)/include"
NPROC=$(getconf _NPROCESSORS_ONLN)

Expand Down

0 comments on commit 0a9bf83

Please sign in to comment.