turn all wave libraries that link against wave_common into standalone…

… libraries
facebookincubator · Oct 23, 2024 · 0b279eb · 0b279eb
1 parent 774929d
commit 0b279eb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/velox/experimental/wave/common/CMakeLists.txt b/velox/experimental/wave/common/CMakeLists.txt
@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-velox_add_library(
+add_library(
   velox_wave_common
   GpuArena.cpp
   Buffer.cpp
@@ -23,7 +23,7 @@ velox_add_library(
   Type.cpp
   ResultStaging.cpp)
 
-velox_link_libraries(
+target_link_libraries(
   velox_wave_common
   velox_exception
   velox_common_base

diff --git a/velox/experimental/wave/dwio/decode/CMakeLists.txt b/velox/experimental/wave/dwio/decode/CMakeLists.txt
@@ -14,6 +14,6 @@
 
 add_subdirectory(tests)
 
-velox_add_library(velox_wave_decode GpuDecoder.cu)
+add_library(velox_wave_decode GpuDecoder.cu)
 
-velox_link_libraries(velox_wave_decode velox_wave_common)
+target_link_libraries(velox_wave_decode velox_wave_common)
diff --git a/velox/experimental/wave/exec/CMakeLists.txt b/velox/experimental/wave/exec/CMakeLists.txt
@@ -12,11 +12,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-velox_add_library(velox_wave_stream OperandSet.cpp Wave.cpp)
+add_library(velox_wave_stream OperandSet.cpp Wave.cpp)
 
-velox_link_libraries(velox_wave_stream Folly::folly fmt::fmt xsimd)
+target_link_libraries(velox_wave_stream Folly::folly fmt::fmt xsimd)
 
-velox_add_library(
+add_library(
   velox_wave_exec
   Aggregation.cpp
   AggregationInstructions.cu
@@ -34,7 +34,7 @@ velox_add_library(
   WaveHiveDataSource.cpp
   WaveSplitReader.cpp)
 
-velox_link_libraries(
+target_link_libraries(
   velox_wave_exec
   velox_wave_vector
   velox_wave_common