Skip to content

Commit

Permalink
Update skip function list of AggregationFuzzerTest and WindowFuzzerTe…
Browse files Browse the repository at this point in the history
…st (#9138)

Summary:
Pull Request resolved: #9138

Update the skip function list of AggregationFuzzerTest and WindowFuzzerTest so that
they can successfully run for 1 hour. This is needed for setting up nightly job of the fuzzer
tests. Functions in the skip function list will be removed once they are unblocked later.

Reviewed By: kgpai

Differential Revision: D55026943

fbshipit-source-id: 31d90ded24f566ff528d8dd710cd6805ceccfc9a
  • Loading branch information
kagamiori authored and facebook-github-bot committed Mar 19, 2024
1 parent ac7f58f commit 0cd6c0a
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
5 changes: 4 additions & 1 deletion velox/functions/prestosql/fuzzer/AggregationFuzzerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ int main(int argc, char** argv) {

// List of functions that have known bugs that cause crashes or failures.
static const std::unordered_set<std::string> skipFunctions = {
// Skip internal functions used only for result verifications.
"$internal$count_distinct",
// https://github.com/facebookincubator/velox/issues/3493
"stddev_pop",
// Lambda functions are not supported yet.
Expand All @@ -111,7 +113,8 @@ int main(int argc, char** argv) {
"approx_set",
"min_by",
"max_by",
"any_value"};
"any_value",
};

using facebook::velox::exec::test::ApproxDistinctResultVerifier;
using facebook::velox::exec::test::ApproxPercentileResultVerifier;
Expand Down
12 changes: 9 additions & 3 deletions velox/functions/prestosql/fuzzer/WindowFuzzerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ getCustomInputGenerators() {

int main(int argc, char** argv) {
facebook::velox::aggregate::prestosql::registerAllAggregateFunctions(
"", false);
"", false, true);
facebook::velox::aggregate::prestosql::registerInternalAggregateFunctions("");
facebook::velox::window::prestosql::registerAllWindowFunctions();
facebook::velox::functions::prestosql::registerAllScalarFunctions();
Expand All @@ -87,12 +87,18 @@ int main(int argc, char** argv) {

// List of functions that have known bugs that cause crashes or failures.
static const std::unordered_set<std::string> skipFunctions = {
// Skip internal functions used only for result verifications.
"$internal$count_distinct",
// https://github.com/facebookincubator/velox/issues/3493
"stddev_pop",
// Lambda functions are not supported yet.
"reduce_agg",
// Skip internal functions used only for result verifications.
"$internal$count_distinct",
// array_agg requires a flag controlling whether to ignore nulls.
"array_agg",
// min_by and max_by are fixed recently, requiring Presto-0.286.
// https://github.com/prestodb/presto/pull/21793
"min_by",
"max_by",
};

// Functions whose results verification should be skipped. These can be
Expand Down

0 comments on commit 0cd6c0a

Please sign in to comment.