Set task wait timeout to 5 mins by default and docs fixes

facebookincubator · Dec 7, 2023 · 1a15f4f · 1a15f4f
1 parent 975ca3a
commit 1a15f4f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/velox/common/memory/Memory.h b/velox/common/memory/Memory.h
@@ -116,8 +116,8 @@ struct MemoryManagerOptions {
 
   /// Specifies the max time to wait for memory reclaim by arbitration. The
   /// memory reclaim might fail if the max wait time has exceeded. If it is
-  /// zero, then there is no timeout.
-  uint64_t memoryReclaimWaitMs{0};
+  /// zero, then there is no timeout. The default is 5 mins.g
+  uint64_t memoryReclaimWaitMs{300'000};
 
   /// Provided by the query system to validate the state after a memory pool
   /// enters arbitration if not null. For instance, Prestissimo provides

diff --git a/velox/docs/index.rst b/velox/docs/index.rst
@@ -10,7 +10,7 @@ Velox Documentation
     functions
     spark_functions
     configs
-    stats
+    metrics
     bindings/python/README_generated_pyvelox
     develop
     programming-guide
diff --git a/velox/docs/stats.rst → velox/docs/metrics.rst b/velox/docs/stats.rst → velox/docs/metrics.rst
@@ -26,6 +26,8 @@ implementation of BaseStatsReporter is required to integrate with a specific
 monitoring service. The metric aggregation granularity and export interval are
 also configured based on the actual used monitoring service.
 
+Velox provides the following five different metric types:
+
 **Count**: tracks the count of events, such as the number of query failures.
 
 **Sum**: tracks the sum of event data point values, such as sum of query scan