Made heap allocator be an aligned allocator for MinMaxNAccumulator

facebookincubator · Mar 13, 2024 · 1ae75ee · 1ae75ee
1 parent 3bd7ed4
commit 1ae75ee
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/velox/functions/prestosql/aggregates/MinMaxAggregates.cpp b/velox/functions/prestosql/aggregates/MinMaxAggregates.cpp
@@ -545,10 +545,15 @@ std::pair<vector_size_t*, vector_size_t*> rawOffsetAndSizes(
 template <typename T, typename Compare>
 struct MinMaxNAccumulator {
   int64_t n{0};
-  std::vector<T, StlAllocator<T>> heapValues;
+  using Allocator = std::conditional_t<
+      std::is_same_v<int128_t, T>,
+      AlignedStlAllocator<T, sizeof(int128_t)>,
+      StlAllocator<T>>;
+  using Heap = std::vector<T, Allocator>;
+  Heap heapValues;
 
   explicit MinMaxNAccumulator(HashStringAllocator* allocator)
-      : heapValues{StlAllocator<T>(allocator)} {}
+      : heapValues{Allocator(allocator)} {}
 
   int64_t getN() const {
     return n;
@@ -926,7 +931,8 @@ exec::AggregateRegistrationResult registerMinMax(const std::string& name) {
             .build());
   }
 
-  // decimal(p,s), bigint -> row(array(decimal(p,s)), bigint) -> array(decimal(p,s))
+  // decimal(p,s), bigint -> row(array(decimal(p,s)), bigint) ->
+  // array(decimal(p,s))
   signatures.push_back(
       exec::AggregateFunctionSignatureBuilder()
           .integerVariable("a_precision")