Fix out of bound

facebookincubator · Oct 23, 2024 · 33c2ef2 · 33c2ef2
1 parent 6dbe18c
commit 33c2ef2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/velox/exec/WindowPartition.cpp b/velox/exec/WindowPartition.cpp
@@ -399,10 +399,12 @@ void WindowPartition::updateKRangeFrameBounds(
       // [0, currentRow] are examined. For following bounds, rows between
       // [currentRow, numRows()) are checked.
       if (isPreceding) {
-        start = lastFoundIndex;
+        start = lastFoundIndex == -1 ? 0 : lastFoundIndex;
         end = currentRow + 1;
       } else {
-        start = lastFoundIndex == -1 ? currentRow : lastFoundIndex;
+        start = lastFoundIndex == -1
+            ? currentRow
+            : std::min(lastFoundIndex, partition_.size() - 1);
         end = partition_.size();
       }
       rawFrameBounds[i] = searchFrameValue(