-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: IN does not handle User errors thrown during eval (#11823)
Summary: Pull Request resolved: #11823 IN does not handle user errors thrown during eval. This means that if the IN is wrapped with a TRY, user errors will still get thrown rather than producing a null. The fuzzer tests demonstrated a case of this, Velox allows creating Timestamps that are large enough that they cannot be represented as milliseconds, there would be an overflow, in this case toMillis throws a user exception. When evaluating IN, the argument is converted to milliseconds and compared to the set of Timestamps. When wrapped in a TRY the IN still throws an exception rather than returning NULL. Reviewed By: bikramSingh91 Differential Revision: D67063377 fbshipit-source-id: 76638810dd11f7532cf19b754edd2a0f01c18f67
- Loading branch information
1 parent
04deeb3
commit 4830651
Showing
2 changed files
with
45 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters