address comments

facebookincubator · Nov 14, 2024 · 4c28fa5 · 4c28fa5
1 parent 39955b0
commit 4c28fa5
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/velox/exec/prefixsort/PrefixSortEncoder.h b/velox/exec/prefixsort/PrefixSortEncoder.h
@@ -60,7 +60,7 @@ class PrefixSortEncoder {
       int32_t encodeSize) const {
     if (value.has_value()) {
       dest[0] = nullsFirst_ ? 1 : 0;
-      encodeNoNulls(value.value(), dest, encodeSize);
+      encodeNoNulls(value.value(), dest + 1, encodeSize - 1);
     } else {
       dest[0] = nullsFirst_ ? 0 : 1;
       std::memset(dest + 1, 0, encodeSize - 1);
@@ -78,15 +78,15 @@ class PrefixSortEncoder {
     // 'value' may be stored in non-contiguous allocation pieces in the row
     // container, so we need to use 'contiguousString' method to read it out.
     auto data = HashStringAllocator::contiguousString(value.value(), storage);
-    if (data.size() < encodeSize - 1) {
-      std::memcpy(dest + 1, data.data(), data.size());
-      std::memset(dest + 1 + data.size(), 0, encodeSize - 1 - data.size());
+    if (data.size() < encodeSize) {
+      std::memcpy(dest, data.data(), data.size());
+      std::memset(dest + data.size(), 0, encodeSize - data.size());
     } else {
-      std::memcpy(dest + 1, data.data(), encodeSize - 1);
+      std::memcpy(dest, data.data(), encodeSize);
     }
 
     if (!ascending_) {
-      for (auto i = 1; i < encodeSize; ++i) {
+      for (auto i = 0; i < encodeSize; ++i) {
         dest[i] = ~dest[i];
       }
     }