code refactor

facebookincubator · Dec 17, 2024 · 557f739 · 557f739
1 parent 24335f4
commit 557f739
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/velox/common/process/TraceContext.cpp b/velox/common/process/TraceContext.cpp
@@ -44,13 +44,12 @@ TraceContext::TraceContext(std::string label, bool isTemporary)
     entry.line = __LINE__;
     int result = snprintf(entry.label, entry.kLabelCapacity, "%s", label_.c_str());
 
-    if (result < 0) {
-      throw std::runtime_error("Encoding error in snprintf");
+    if (FOLLY_UNLIKELY(result < 0)) {
+      entry.label[0] = '\0';
     }
 
     if (result >= entry.kLabelCapacity) {
       std::cerr << "Warning: label truncated in snprintf" << std::endl;
-      entry.label[entry.kLabelCapacity - 1] = '\0';
     }
   });
   traceData_->withValue([&](auto& counts) {