Add support for another repo to take reference from.

facebookincubator · Jan 11, 2024 · 57d8781 · 57d8781
1 parent db5aa54
commit 57d8781
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/.github/workflows/experimental.yml b/.github/workflows/experimental.yml
@@ -84,7 +84,7 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: aggregation
-          path: velox/_build/debug/velox/exec/tests/velox_aggregation_fuzzer_test
+          path: velox/_build/debug/velox/functions/prestosql/fuzzer/velox_aggregation_fuzzer_test
 
       - name: Upload spark fuzzer
         uses: actions/upload-artifact@v3
@@ -115,12 +115,9 @@ jobs:
         with:
           name: aggregation
 
-      - name: "Start Presto Java"
-        - run: |
-            - /opt/start-prestojava.sh
-
       - name: "Run Aggregate Fuzzer"
         run: |
+          /opt/start-prestojava.sh 2>&1 >> /tmp/server.log &
           mkdir -p /tmp/aggregate_fuzzer_repro/
           rm -rfv /tmp/aggregate_fuzzer_repro/*
           chmod -R 777 /tmp/aggregate_fuzzer_repro
@@ -134,6 +131,7 @@ jobs:
                 --enable_sorted_aggregations=true \
                 --presto_url=http://127.0.0.1:8080 \
           && echo -e "\n\nAggregation fuzzer run finished successfully."
+
       - name: Archive aggregate production artifacts
         if: always()
         uses: actions/upload-artifact@v3

diff --git a/scripts/prestojava-container.dockerfile b/scripts/prestojava-container.dockerfile
@@ -28,7 +28,7 @@ ARG PRESTO_CLI_JAR=presto-cli-$PRESTO_VERSION-executable.jar
 ENV PRESTO_HOME="/opt/presto-server"
 RUN cp $PRESTO_CLI_JAR /opt/presto-cli
 
-RUN dnf install -y java-11-openjdk less procps python3 \
+RUN dnf install -y java-11-openjdk less procps python3 tzdata \
     && ln -s $(which python3) /usr/bin/python \
     && tar -zxf $PRESTO_PKG \
     && mv ./presto-server-$PRESTO_VERSION $PRESTO_HOME \
@@ -39,6 +39,10 @@ RUN dnf install -y java-11-openjdk less procps python3 \
     && mkdir -p $PRESTO_HOME/etc/data \
     && mkdir -p /usr/lib/presto/utils
 
+
+# Setting timezone to deal with Velox timezone conversion problem
+ENV TZ=America/Bahia_Banderas
+
 COPY scripts/etc/config.properties.example $PRESTO_HOME/etc/config.properties
 COPY scripts/etc/jvm.config.example $PRESTO_HOME/etc/jvm.config
 COPY scripts/etc/node.properties $PRESTO_HOME/etc/node.properties

diff --git a/scripts/start-prestojava.sh b/scripts/start-prestojava.sh
@@ -15,4 +15,8 @@
 
 set -e
 
-$PRESTO_HOME/bin/launcher run
+nohup $PRESTO_HOME/bin/launcher --pid-file=/tmp/pidfile  run >  /tmp/server.log
+#wait a few seconds for presto to start
+sleep 60
+echo 'CREATE SCHEMA hive.tpch;' > /tmp/hive_create.sql
+/opt/presto-cli --server 127.0.0.1:8080 --file /tmp/hive_create.sql