{debug} Install CUDA driver as well

facebookincubator · Apr 18, 2024 · 6c1e734 · 6c1e734
1 parent ca5665c
commit 6c1e734
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 14 deletions.
diff --git a/.github/workflows/linux-build.yml b/.github/workflows/linux-build.yml
@@ -77,7 +77,7 @@ jobs:
           # docker container before. It simplifies testing new/different versions
           if ! yum list installed cuda-nvcc-$(echo ${CUDA_VERSION} | tr '.' '-') 1>/dev/null; then
             source scripts/setup-centos8.sh
-            install_cuda ${CUDA_VERSION}
+            install_cuda_runtime ${CUDA_VERSION}
           fi
 
       - uses: assignUser/stash/restore@v1

diff --git a/.github/workflows/linux-nightly-build.yml b/.github/workflows/linux-nightly-build.yml
@@ -36,10 +36,6 @@ jobs:
     if: ${{ github.repository == 'facebookincubator/velox' }}
     runs-on: 4-core-ubuntu-gpu-t4
     steps:
-      - name: Print CUDA version
-        run: |
-          nvidia-smi
-
   adapters:
     name: Linux release with adapters
     # prevent errors when forks ff their main branch
@@ -66,12 +62,13 @@ jobs:
 
       - name: Install Dependencies
         run: |
-          # Allows to install arbitrary cuda-version whithout needing to update
-          # docker container before. It simplifies testing new/different versions
-          if ! yum list installed cuda-nvcc-$(echo ${CUDA_VERSION} | tr '.' '-') 1>/dev/null; then
-            source scripts/setup-centos8.sh
-            install_cuda_toolkit ${CUDA_VERSION}
-          fi
+          source scripts/setup-centos8.sh
+          install_cuda_runtime ${CUDA_VERSION}
+          install_cuda_driver
+
+      - name: Print CUDA version
+        run: |
+          nvidia-smi
 
       - uses: assignUser/stash/restore@v1
         with:

diff --git a/scripts/setup-centos8.sh b/scripts/setup-centos8.sh
@@ -185,16 +185,16 @@ function install_duckdb {
   fi
 }
 
-function install_cuda {
+function install_cuda_runtime {
   # See https://developer.nvidia.com/cuda-downloads
   dnf config-manager --add-repo https://developer.download.nvidia.com/compute/cuda/repos/rhel8/x86_64/cuda-rhel8.repo
   yum install -y cuda-nvcc-$(echo $1 | tr '.' '-') cuda-cudart-devel-$(echo $1 | tr '.' '-')
 }
 
-function install_cuda_toolkit {
+function install_cuda_driver {
   # See https://developer.nvidia.com/cuda-downloads
   dnf config-manager --add-repo https://developer.download.nvidia.com/compute/cuda/repos/rhel8/x86_64/cuda-rhel8.repo
-  yum install -y cuda-toolkit-$(echo $1 | tr '.' '-')
+  yum install -y nvidia-driver-cuda
 }
 
 function install_velox_deps {