-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add lib stemmer in setup scripts (#10984)
Summary: The early merged pr (38f9a1f) was reverted by #10965 due to this issue: #10963. In the original impl., a patch is expected to be applied to add `-fPIC` before building lib stemmer, but when building docker image (ghcr.io/facebookincubator/velox-dev:centos9), that patch file is not available to use due to the copied setup script outside velox repo is executed. See code: https://github.com/facebookincubator/velox/blob/7f2d7adaa1544c72129fd1c8d0766755ff354455/scripts/centos.dockerfile#L22 This pr proposes the installation of lib stemmer with the above issue fixed. Pull Request resolved: #10984 Reviewed By: DanielHunte Differential Revision: D63344087 Pulled By: Yuhta fbshipit-source-id: a1467f5392ef828efdd219d0b7f1dfe0003d00ed
- Loading branch information
1 parent
52750de
commit 783c233
Showing
4 changed files
with
41 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters