Skip to content

Commit

Permalink
List initialize blobStream_ in StringDictionaryColumnReader (#6855)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #6855

Below diffs allow us to add more private members to initialization list. Yay!

Reviewed By: Magoja

Differential Revision: D49840659

fbshipit-source-id: 42a33d5b55d3be27c33948ced14c9dc79770712c
  • Loading branch information
Patrick Sullivan authored and facebook-github-bot committed Oct 5, 2023
1 parent a044974 commit 83c2f63
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions velox/dwio/dwrf/reader/ColumnReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1149,6 +1149,10 @@ StringDictionaryColumnReader::StringDictionaryColumnReader(
dictionaryCount_(stripe.getEncoding(encodingKey).dictionarysize()),
lastStrideIndex_(-1),
provider_(stripe.getStrideIndexProvider()),
blobStream_(stripe.getStream(
encodingKey.forKind(proto::Stream_Kind_DICTIONARY_DATA),
streamLabels.label(),
false)),
returnFlatVector_(stripe.getRowReaderOptions().getReturnFlatVector()) {
dictIndex_ = makeRleDecoder(
encodingKey,
Expand All @@ -1168,11 +1172,6 @@ StringDictionaryColumnReader::StringDictionaryColumnReader(
proto::Stream_Kind_LENGTH,
memoryPool_);

blobStream_ = stripe.getStream(
encodingKey.forKind(proto::Stream_Kind_DICTIONARY_DATA),
streamLabels.label(),
false);

// handle in dictionary stream
std::unique_ptr<dwio::common::SeekableInputStream> inDictStream =
stripe.getStream(
Expand Down

0 comments on commit 83c2f63

Please sign in to comment.