Fix

facebookincubator · Nov 20, 2024 · 98285dd · 98285dd
1 parent a71d761
commit 98285dd
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/velox/dwio/common/tests/utils/E2EFilterTestBase.cpp b/velox/dwio/common/tests/utils/E2EFilterTestBase.cpp
@@ -343,7 +343,6 @@ void E2EFilterTestBase::testRowGroupSkip(
   for (auto& field : filterable) {
     VectorPtr child = getChildBySubfield(batches[0].get(), Subfield(field));
     if (child->typeKind() == TypeKind::BIGINT ||
-        child->typeKind() == TypeKind::HUGEINT ||
         child->typeKind() == TypeKind::VARCHAR) {
       specs.emplace_back();
       specs.back().field = field;

diff --git a/velox/dwio/common/tests/utils/FilterGenerator.h b/velox/dwio/common/tests/utils/FilterGenerator.h
@@ -337,10 +337,6 @@ class ColumnStats : public AbstractColumnStats {
         }
       }
     }
-    if constexpr (std::is_same_v<T, int128_t>) {
-      return std::make_unique<velox::common::HugeintRange>(
-          max, max, false);
-    }
     return std::make_unique<velox::common::BigintRange>(
         getIntegerValue(max), getIntegerValue(max), false);
   }

diff --git a/velox/dwio/parquet/tests/reader/E2EFilterTest.cpp b/velox/dwio/parquet/tests/reader/E2EFilterTest.cpp
@@ -443,7 +443,7 @@ TEST_F(E2EFilterTest, longDecimalDirect) {
               true);
         },
         true,
-        {},
+        {"longdecimal_val"},
         20);
   }
 
@@ -456,7 +456,7 @@ TEST_F(E2EFilterTest, longDecimalDirect) {
             {-479, HugeInt::build(1546093991, 4054979645)});
       },
       false,
-      {},
+      {"longdecimal_val"},
       20);
 }
 

diff --git a/velox/type/tests/FilterTest.cpp b/velox/type/tests/FilterTest.cpp
@@ -76,6 +76,7 @@ TEST(FilterTest, isNull) {
 
   EXPECT_FALSE(isNull.testNonNull());
   EXPECT_FALSE(isNull.testInt64(10));
+  EXPECT_FALSE(isNull.testInt128(10));
 
   EXPECT_EQ("Filter(IsNull, deterministic, null allowed)", isNull.toString());
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -443,7 +443,7 @@ TEST_F(E2EFilterTest, longDecimalDirect) { @@
                   true);
             },
             true,
-            {},
+            {"longdecimal_val"},
 );
       }
@@ Expand All / @@ -456,7 +456,7 @@ TEST_F(E2EFilterTest, longDecimalDirect) { @@
                 {-479, HugeInt::build(1546093991, 4054979645)});
           },
           false,
-          {},
+          {"longdecimal_val"},
 );
     }
@@ Expand Down @@