Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix build for devtoolset-9 on CentOS 7 (#8214)
Summary: devtoolset-9 has some issue on choosing the right template when building unit tests ``` /root/velox/velox/exec/tests/AggregateFunctionRegistryTest.cpp: In member function 'virtual void facebook::velox::exec::test::FunctionRegistryTest_multipleNames_Test::TestBody()': /root/velox/velox/exec/tests/AggregateFunctionRegistryTest.cpp:273:26: error: call of overloaded 'registerAggregateFunction(<brace-enclosed initializer list>, std::vector<std::shared_ptr<facebook::velox::exec::AggregateFunctionSignature> >&, facebook::velox::exec::test::FunctionRegistryTest_multipleNames_Test::TestBody()::<lambda(facebook::velox::core::AggregationNode::Step, const std::vector<std::shared_ptr<const facebook::velox::Type> >&, const TypePtr&, const facebook::velox::core::QueryConfig&)>&, bool, bool)' is ambiguous 273 | /*overwrite*/ false); | ^ In file included from /root/velox/velox/exec/tests/AggregateFunctionRegistryTest.cpp:19: /root/velox/./velox/exec/Aggregate.h:421:29: note: candidate: 'facebook::velox::exec::AggregateRegistrationResult facebook::velox::exec::registerAggregateFunction(const string&, const std::vector<std::shared_ptr<facebook::velox::exec::AggregateFunctionSignature> >&, const AggregateFunctionFactory&, bool, bool)' 421 | AggregateRegistrationResult registerAggregateFunction( | ^~~~~~~~~~~~~~~~~~~~~~~~~ /root/velox/./velox/exec/Aggregate.h:430:42: note: candidate: 'std::vector<facebook::velox::exec::AggregateRegistrationResult> facebook::velox::exec::registerAggregateFunction(const std::vector<std::basic_string<char> >&, const std::vector<std::shared_ptr<facebook::velox::exec::AggregateFunctionSignature> >&, const AggregateFunctionFactory&, bool, bool)' 430 | std::vector<AggregateRegistrationResult> registerAggregateFunction( | ^~~~~~~~~~~~~~~~~~~~~~~~~ ```` Pull Request resolved: #8214 Reviewed By: amitkdutta Differential Revision: D52820297 Pulled By: kgpai fbshipit-source-id: 21a128d6e0f34606b9ced38ed399ec7874a35e32
- Loading branch information