Skip to content

Commit

Permalink
fix(fuzzer): Skip check of verified iterations in WindowFuzzer when v…
Browse files Browse the repository at this point in the history
…erification is not enabled (#11918)

Summary: Pull Request resolved: #11918

Reviewed By: yuandagits

Differential Revision: D67497422

fbshipit-source-id: 839a2675ce91084662afaa175537e302e5af599b
  • Loading branch information
kagamiori authored and facebook-github-bot committed Dec 20, 2024
1 parent 0450c39 commit c519980
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions velox/exec/fuzzer/WindowFuzzer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -560,14 +560,17 @@ void WindowFuzzer::go() {
}

stats_.print(iteration);
// Check that at least half of the iterations were verified, either against
// the reference DB or through custom result verifiers.
// stats_.numVerificationSkipped tracks the number of iterations verified
// through custom result verifiers.
VELOX_CHECK_GE(
(stats_.numVerified + stats_.numVerificationSkipped) / (double)iteration,
0.5);
printSignatureStats();
if (FLAGS_enable_window_reference_verification) {
// Check that at least half of the iterations were verified, either against
// the reference DB or through custom result verifiers.
// stats_.numVerificationSkipped tracks the number of iterations verified
// through custom result verifiers.
VELOX_CHECK_GE(
(stats_.numVerified + stats_.numVerificationSkipped) /
(double)iteration,
0.5);
}
}

void WindowFuzzer::go(const std::string& /*planPath*/) {
Expand Down

0 comments on commit c519980

Please sign in to comment.