Fix: Review and address Use parentheses within macros around paramete…

…r names bug fix bug fix
facebookincubator · Dec 10, 2024 · cb49aa9 · cb49aa9
1 parent 4cffa4b
commit cb49aa9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/velox/common/base/SpillStats.cpp b/velox/common/base/SpillStats.cpp
@@ -134,7 +134,7 @@ bool SpillStats::operator<(const SpillStats& other) const {
     } else if (counter > other.counter) { \
       ++gtCount;                          \
     }                                     \
-  } while (0);
+  } while (0)
 
   UPDATE_COUNTER(spillRuns);
   UPDATE_COUNTER(spilledInputBytes);

diff --git a/velox/core/Metaprogramming.h b/velox/core/Metaprogramming.h
@@ -151,7 +151,7 @@ struct has_method {
         -> decltype(std::declval<__T>().MethodName(args...)) { \
       return {};                                               \
     }                                                          \
-  };
+  }
 
 // Calling Name::resolve<T>::type will return T::TypeName if T::TypeName
 // exists, and otherwise will return T::OtherTypeName (it's existence is not
@@ -169,5 +169,5 @@ struct has_method {
         std::void_t<decltype(sizeof(typename __T::TypeName))>> {     \
       using type = typename __T::TypeName;                           \
     };                                                               \
-  };
+  }
 } // namespace facebook::velox::util
diff --git a/velox/tpch/gen/dbgen/build.cpp b/velox/tpch/gen/dbgen/build.cpp
@@ -38,7 +38,7 @@ namespace facebook::velox::tpch::dbgen {
 #define V_STR(avg, seed, tgt) \
   tpch_a_rnd((int)(avg * V_STR_LOW), (int)(avg * V_STR_HGH), seed, tgt)
 #define TEXT(avg, seed, tgt) \
-  dbg_text(tgt, (int)(avg * V_STR_LOW), (int)(avg * V_STR_HGH), seed)
+  dbg_text(tgt, static_cast<int>((avg) * V_STR_LOW), static_cast<int>((avg) * V_STR_HGH), seed)
 static void gen_phone PROTO((DSS_HUGE ind, char* target, seed_t* seed));
 
 DSS_HUGE