Skip to content

Commit

Permalink
Fix call to unsafeResize in StructColumnReader (#7461)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #7461

Ensure call to unsafeResize sets new rows to false in StructColumnReader.
When adding unsafeRowApi (D50577808) I missed setting one call to false instead of the default true.

Reviewed By: Yuhta

Differential Revision: D51091937

fbshipit-source-id: 441ed2b86d81fac6f703dd84f25a95b4e73752c7
  • Loading branch information
Krishna Pai authored and facebook-github-bot committed Nov 8, 2023
1 parent d498bd4 commit d2122ce
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion velox/dwio/dwrf/reader/ColumnReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1864,7 +1864,7 @@ void StructColumnReader::next(
DWIO_ENSURE_GE(childrenVectors.size(), children_.size());

// Resize rowVector
rowVector->unsafeResize(numValues);
rowVector->unsafeResize(numValues, false);
}

BufferPtr nulls = readNulls(numValues, result, incomingNulls);
Expand Down

0 comments on commit d2122ce

Please sign in to comment.