use correct extension

facebookincubator · May 14, 2024 · df5e2a6 · df5e2a6
1 parent c892266
commit df5e2a6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 332 deletions.
diff --git a/.github/workflows/build-metrics.yml b/.github/workflows/build-metrics.yml
@@ -150,8 +150,7 @@ jobs:
           CONBENCH_PASSWORD: "${{ secrets.CONBENCH_PASSWORD }}"
         run: |
           cd scripts/bm-report
-          nix-shell --run "quarto render report.Rmd"
-          nix-shell --run "quarto --version"
+          nix-shell --run "quarto render report.qmd"
 
       - name: Push Documentation
         # if: ${{ github.event_name == 'push' && github.repository == 'facebookincubator/velox'}}

diff --git a/scripts/bm-report/report.Rmd b/scripts/bm-report/report.Rmd
diff --git a/scripts/bm-report/report.qmd b/scripts/bm-report/report.qmd
@@ -25,7 +25,6 @@ format:
 library(gt)
 library(ggplot2)
 library(plotly)
-library(gdata)
 library(dplyr)
 library(purrr)
 
@@ -230,22 +229,9 @@ link_times |>
 ```{r big-objects}
 size_formatter <- function(x) {
   function(x) {
-    gdata::humanReadable(x, standard = "Unix")
+    prettyunits::pretty_bytes(x)
   }
 }
-create_byte <- function(bytes) {
-  stopifnot(is.numeric(bytes))
-  structure(
-    list(bytes = bytes),
-    class = "BytesObject"
-  )
-}
-Bytes <- Vectorize(create_byte, SIMPLIFY = FALSE)
-
-print.BytesObject <- function(x, ...) {
-  human_readable <- prettyunits::pretty_bytes(x$bytes)
-  cat(human_readable)
-}
 
 object_sizes <- results |>
   filter(endsWith(tags.source, "size"), commit.sha == newest_sha)  |>
@@ -262,7 +248,7 @@ sizes_plot <- results |>
   facet_wrap(~type) +
   geom_line() +
   geom_point() +
-  # scale_y_continuous(labels = size_formatter()) +
+  scale_y_continuous(labels = size_formatter()) +
   scale_x_datetime() +
   labs(
     title = "Velox Object Sizes",