Add unit tests for struct Converter

Add unit tests for struct Converter and Conversions.h. struct Converter holds the core logic for casting between scalar types. Source of the test cases are CastExprTest.cpp and https://facebookincubator.github.io/velox/functions/presto/conversion.html
facebookincubator · Dec 6, 2023 · e26180a · e26180a
1 parent 14dc44b
commit e26180a
Show file tree

Hide file tree

Showing 3 changed files with 1,012 additions and 5 deletions.
diff --git a/velox/expression/tests/CastExprTest.cpp b/velox/expression/tests/CastExprTest.cpp
@@ -1265,10 +1265,9 @@ TEST_F(CastExprTest, truncateVsRound) {
       "tinyint", {1111111, 2, 3, 1000, -100101}, {71, 2, 3, -24, -5});
 
   setCastIntByTruncate(false);
-  EXPECT_THROW(
-      (testCast<int32_t, int8_t>(
-          "tinyint", {1111111, 2, 3, 1000, -100101}, {71, 2, 3, -24, -5})),
-      VeloxUserError);
+  testCast<int32_t, int8_t>("tinyint", {2, 3}, {2, 3});
+  testCast<int32_t, int8_t>(
+      "tinyint", {1111111, 1000, -100101}, {0, 0, 0}, true);
 }
 
 TEST_F(CastExprTest, nullInputs) {

diff --git a/velox/type/tests/CMakeLists.txt b/velox/type/tests/CMakeLists.txt
@@ -22,7 +22,8 @@ add_executable(
   SubfieldTest.cpp
   TimestampConversionTest.cpp
   VariantTest.cpp
-  TimestampTest.cpp)
+  TimestampTest.cpp
+  ConversionsTest.cpp)
 
 add_test(velox_type_test velox_type_test)