Extend join fuzzer to cover group execution mode

facebookincubator · Mar 13, 2024 · e7bee61 · e7bee61
1 parent 86f559c
commit e7bee61
Show file tree

Hide file tree

Showing 7 changed files with 459 additions and 126 deletions.
diff --git a/velox/core/PlanFragment.cpp b/velox/core/PlanFragment.cpp
@@ -28,4 +28,14 @@ bool PlanFragment::canSpill(const QueryConfig& queryConfig) const {
              }) != nullptr;
 }
 
+std::string executionStrategyToString(ExecutionStrategy strategy) {
+  switch (strategy) {
+    case ExecutionStrategy::kGrouped:
+      return "GROUPED";
+    case ExecutionStrategy::kUngrouped:
+      return "UNGROUPED";
+    default:
+      return fmt::format("UNKNOWN: {}", static_cast<int>(strategy));
+  }
+}
 } // namespace facebook::velox::core
diff --git a/velox/core/PlanFragment.h b/velox/core/PlanFragment.h
@@ -35,6 +35,8 @@ enum class ExecutionStrategy {
   kGrouped,
 };
 
+std::string executionStrategyToString(ExecutionStrategy strategy);
+
 /// Contains some information on how to execute the fragment of a plan.
 /// Used to construct Task.
 struct PlanFragment {

diff --git a/velox/core/tests/PlanFragmentTest.cpp b/velox/core/tests/PlanFragmentTest.cpp
@@ -322,3 +322,14 @@ TEST_F(PlanFragmentTest, hashJoin) {
         testData.expectedCanSpill);
   }
 }
+
+TEST_F(PlanFragmentTest, executionStrategyToString) {
+  ASSERT_EQ(
+      executionStrategyToString(core::ExecutionStrategy::kUngrouped),
+      "UNGROUPED");
+  ASSERT_EQ(
+      executionStrategyToString(core::ExecutionStrategy::kGrouped), "GROUPED");
+  ASSERT_EQ(
+      executionStrategyToString(static_cast<core::ExecutionStrategy>(999)),
+      "UNKNOWN: 999");
+}