Fix REAL and DOUBLE hash functions

facebookincubator · Jun 6, 2024 · ee88f95 · ee88f95
1 parent 8ea6979
commit ee88f95
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/velox/connectors/hive/HivePartitionFunction.cpp b/velox/connectors/hive/HivePartitionFunction.cpp
@@ -76,7 +76,9 @@ inline uint32_t hashOne<TypeKind::INTEGER>(const int32_t& value) {
 
 template <>
 inline uint32_t hashOne<TypeKind::REAL>(const float& value) {
-  return static_cast<uint32_t>(*reinterpret_cast<const int32_t*>(&value));
+  uint32_t ret;
+  memcpy(&ret, &value, sizeof ret);
+  return ret;
 }
 
 template <>
@@ -86,7 +88,9 @@ inline uint32_t hashOne<TypeKind::BIGINT>(const int64_t& value) {
 
 template <>
 inline uint32_t hashOne<TypeKind::DOUBLE>(const double& value) {
-  return hashInt64(*reinterpret_cast<const int64_t*>(&value));
+  int64_t val;
+  memcpy(&val, &value, sizeof val);
+  return hashInt64(val);
 }
 
 template <>