Remove c-ares

facebookincubator · Jun 28, 2024 · fa1f31e · fa1f31e
1 parent d0767bd
commit fa1f31e
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 85 deletions.
diff --git a/.github/workflows/linux-build.yml b/.github/workflows/linux-build.yml
@@ -62,7 +62,6 @@ jobs:
       Protobuf_SOURCE: BUNDLED # can be removed after #10134 is merged
       simdjson_SOURCE: BUNDLED
       xsimd_SOURCE: BUNDLED
-      c-ares_SOURCE: BUNDLED
       CUDA_VERSION: "12.4"
     steps:
       - uses: actions/checkout@v4

diff --git a/CMake/Findc-ares.cmake b/CMake/Findc-ares.cmake
diff --git a/CMake/resolve_dependency_modules/c-ares.cmake b/CMake/resolve_dependency_modules/c-ares.cmake
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -455,13 +455,10 @@ add_compile_definitions(FOLLY_HAVE_INT128_T=1)
 set_source(folly)
 resolve_dependency(folly)
 
-# Spark qury runner depends on absl, c-ares, grpc.
+# Spark qury runner depends on absl, grpc.
 set_source(absl)
 resolve_dependency(absl 20240116 EXACT)
 
-set_source(c-ares)
-resolve_dependency(c-ares)
-
 set_source(gRPC)
 resolve_dependency(gRPC 1.48.1 EXACT)
 

diff --git a/velox/functions/sparksql/fuzzer/CMakeLists.txt b/velox/functions/sparksql/fuzzer/CMakeLists.txt
@@ -77,7 +77,7 @@ target_link_libraries(
   ZLIB::ZLIB
   re2::re2
   gRPC::address_sorting
-  cares::cares
+  c-ares::cares
   OpenSSL::SSL
   OpenSSL::Crypto
   pthread
@@ -106,7 +106,7 @@ target_link_libraries(
   ZLIB::ZLIB
   re2::re2
   gRPC::address_sorting
-  cares::cares
+  c-ares::cares
   gRPC::upb
   OpenSSL::SSL
   OpenSSL::Crypto

diff --git a/velox/functions/sparksql/fuzzer/tests/CMakeLists.txt b/velox/functions/sparksql/fuzzer/tests/CMakeLists.txt
@@ -69,7 +69,7 @@ target_link_libraries(
   ZLIB::ZLIB
   re2::re2
   gRPC::address_sorting
-  cares::cares
+  c-ares::cares
   gRPC::upb
   OpenSSL::SSL
   OpenSSL::Crypto