Refactor HiveConfig

facebookincubator · Nov 27, 2023 · ff5a163 · ff5a163
1 parent ea28f35
commit ff5a163
Show file tree

Hide file tree

Showing 21 changed files with 722 additions and 324 deletions.
diff --git a/velox/connectors/Connector.h b/velox/connectors/Connector.h
@@ -237,7 +237,7 @@ class ConnectorQueryCtx {
   ConnectorQueryCtx(
       memory::MemoryPool* operatorPool,
       memory::MemoryPool* connectorPool,
-      const Config* connectorConfig,
+      const Config* connectorSession,
       const common::SpillConfig* spillConfig,
       std::unique_ptr<core::ExpressionEvaluator> expressionEvaluator,
       cache::AsyncDataCache* cache,
@@ -247,7 +247,7 @@ class ConnectorQueryCtx {
       int driverId)
       : operatorPool_(operatorPool),
         connectorPool_(connectorPool),
-        config_(connectorConfig),
+        connectorSession_(connectorSession),
         spillConfig_(spillConfig),
         expressionEvaluator_(std::move(expressionEvaluator)),
         cache_(cache),
@@ -256,7 +256,7 @@ class ConnectorQueryCtx {
         taskId_(taskId),
         driverId_(driverId),
         planNodeId_(planNodeId) {
-    VELOX_CHECK_NOT_NULL(connectorConfig);
+    VELOX_CHECK_NOT_NULL(connectorSession);
   }
 
   /// Returns the associated operator's memory pool which is a leaf kind of
@@ -272,8 +272,8 @@ class ConnectorQueryCtx {
     return connectorPool_;
   }
 
-  const Config* config() const {
-    return config_;
+  const Config* connectorSession() const {
+    return connectorSession_;
   }
 
   const common::SpillConfig* spillConfig() const {
@@ -315,7 +315,7 @@ class ConnectorQueryCtx {
  private:
   memory::MemoryPool* const operatorPool_;
   memory::MemoryPool* const connectorPool_;
-  const Config* config_;
+  const Config* connectorSession_;
   const common::SpillConfig* const spillConfig_;
   std::unique_ptr<core::ExpressionEvaluator> expressionEvaluator_;
   cache::AsyncDataCache* cache_;
@@ -328,9 +328,7 @@ class ConnectorQueryCtx {
 
 class Connector {
  public:
-  explicit Connector(
-      const std::string& id)
-      : id_(id) {}
+  explicit Connector(const std::string& id) : id_(id) {}
 
   virtual ~Connector() = default;