Remove unused exception parameter from velox/exec/Driver.cpp

Summary: `-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it. This: ``` try { ... } catch (exception& e) { // no use of e } ``` should instead be written as ``` } catch (exception&) { ``` If the code compiles, this is safe to land. Reviewed By: palmje Differential Revision: D56724172 fbshipit-source-id: 41462ab2c0f028e68f10f4cc3953e5cb1cd5c27c
facebookincubator · Apr 30, 2024 · ffc28ac · ffc28ac
1 parent 44e9ec1
commit ffc28ac
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 17 deletions.
diff --git a/velox/exec/Driver.cpp b/velox/exec/Driver.cpp
@@ -377,7 +377,7 @@ void Driver::enqueueInternal() {
     auto stopGuard = folly::makeGuard([&]() { opCallStatus_.stop(); });    \
     call;                                                                  \
     recordSilentThrows(*operatorPtr);                                      \
-  } catch (const VeloxException& e) {                                      \
+  } catch (const VeloxException&) {                                        \
     throw;                                                                 \
   } catch (const std::exception& e) {                                      \
     VELOX_FAIL(                                                            \

diff --git a/velox/exec/HashProbe.cpp b/velox/exec/HashProbe.cpp
@@ -1668,7 +1668,7 @@ void HashProbe::spillOutput(const std::vector<HashProbe*>& operators) {
       // this runs.
       try {
         spillTask->move();
-      } catch (const std::exception& e) {
+      } catch (const std::exception&) {
       }
     }
   });
@@ -1770,7 +1770,7 @@ SpillPartitionSet HashProbe::spillTable() {
       // this runs.
       try {
         spillTask->move();
-      } catch (const std::exception& e) {
+      } catch (const std::exception&) {
       }
     }
   });

diff --git a/velox/exec/tests/HashJoinTest.cpp b/velox/exec/tests/HashJoinTest.cpp
@@ -203,7 +203,7 @@ std::pair<int32_t, int32_t> numTaskSpillFiles(const exec::Task& task) {
 void abortPool(memory::MemoryPool* pool) {
   try {
     VELOX_FAIL("Manual MemoryPool Abortion");
-  } catch (const VeloxException& error) {
+  } catch (const VeloxException&) {
     pool->abort(std::current_exception());
   }
 }

diff --git a/velox/exec/tests/JoinFuzzer.cpp b/velox/exec/tests/JoinFuzzer.cpp
@@ -1020,7 +1020,7 @@ void JoinFuzzer::verify(core::JoinType joinType) {
           VELOX_CHECK(
               assertEqualResults({expected}, {actual}),
               "Logically equivalent plans produced different results");
-        } catch (const VeloxException& e) {
+        } catch (const VeloxException&) {
           LOG(ERROR) << "Expected\n"
                      << expected->toString(0, expected->size()) << "\nActual\n"
                      << actual->toString(0, actual->size());

diff --git a/velox/expression/tests/ExpressionFuzzerVerifier.cpp b/velox/expression/tests/ExpressionFuzzerVerifier.cpp
@@ -250,7 +250,7 @@ void ExpressionFuzzerVerifier::retryWithTry(
                 false, // canThrow
                 columnsToWrapInLazy)
             .result;
-  } catch (const std::exception& e) {
+  } catch (const std::exception&) {
     if (options_.findMinimalSubexpression) {
       computeMinimumSubExpression(
           {&execCtx_, {false, ""}},
@@ -281,7 +281,7 @@ void ExpressionFuzzerVerifier::retryWithTry(
                        : nullptr,
           false, // canThrow
           columnsToWrapInLazy);
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
       if (options_.findMinimalSubexpression) {
         computeMinimumSubExpression(
             {&execCtx_, {false, ""}},
@@ -339,7 +339,7 @@ void ExpressionFuzzerVerifier::go() {
           resultVectors ? BaseVector::copy(*resultVectors) : nullptr,
           true, // canThrow
           columnsToWrapInLazy);
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
       if (options_.findMinimalSubexpression) {
         computeMinimumSubExpression(
             {&execCtx_, {false, ""}},

diff --git a/velox/expression/tests/ExpressionVerifier.cpp b/velox/expression/tests/ExpressionVerifier.cpp
@@ -431,7 +431,7 @@ class MinimalSubExpressionFinder {
           results ? BaseVector::copy(*results) : nullptr,
           true, // canThrow
           columnsToWrapInLazy);
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
       success = false;
     }
     FLAGS_minloglevel = 0;

diff --git a/velox/functions/lib/Re2Functions.cpp b/velox/functions/lib/Re2Functions.cpp
@@ -217,7 +217,7 @@ class Re2MatchConstantPattern final : public exec::VectorFunction {
     exec::LocalDecodedVector toSearch(context, *args[0], rows);
     try {
       checkForBadPattern(re_);
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
       context.setErrors(rows, std::current_exception());
       return;
     }
@@ -288,7 +288,7 @@ class Re2SearchAndExtractConstantPattern final : public exec::VectorFunction {
     // apply() will not be invoked if the selection is empty.
     try {
       checkForBadPattern(re_);
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
       context.setErrors(rows, std::current_exception());
       return;
     }
@@ -312,7 +312,7 @@ class Re2SearchAndExtractConstantPattern final : public exec::VectorFunction {
     if (const auto groupId = getIfConstant<T>(*args[2])) {
       try {
         checkForBadGroupId(*groupId, re_);
-      } catch (const std::exception& e) {
+      } catch (const std::exception&) {
         context.setErrors(rows, std::current_exception());
         return;
       }
@@ -825,7 +825,7 @@ class LikeWithRe2 final : public exec::VectorFunction {
     // apply() will not be invoked if the selection is empty.
     try {
       checkForBadPattern(*re_);
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
       context.setErrors(rows, std::current_exception());
       return;
     }
@@ -1058,7 +1058,7 @@ class Re2ExtractAllConstantPattern final : public exec::VectorFunction {
     VELOX_CHECK(args.size() == 2 || args.size() == 3);
     try {
       checkForBadPattern(re_);
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
       context.setErrors(rows, std::current_exception());
       return;
     }
@@ -1083,7 +1083,7 @@ class Re2ExtractAllConstantPattern final : public exec::VectorFunction {
       //
       try {
         checkForBadGroupId(*_groupId, re_);
-      } catch (const std::exception& e) {
+      } catch (const std::exception&) {
         context.setErrors(rows, std::current_exception());
         return;
       }

diff --git a/velox/functions/prestosql/benchmarks/URLBenchmark.cpp b/velox/functions/prestosql/benchmarks/URLBenchmark.cpp
@@ -127,7 +127,7 @@ struct FollyUrlExtractPortFunction {
       result = parsedUrl.port();
     } catch (const folly::ConversionError&) {
       return false;
-    } catch (const std::invalid_argument& e) {
+    } catch (const std::invalid_argument&) {
       return false;
     }
     return true;
@@ -154,7 +154,7 @@ struct FollyUrlExtractParameterFunction {
           strncpy(result.data(), pair.second.c_str(), pair.second.length());
         }
       }
-    } catch (const std::invalid_argument& e) {
+    } catch (const std::invalid_argument&) {
       return false;
     }
     return false;