-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyVelox builds fail on CI #10963
Comments
cc: @assignUser |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this issue
Sep 11, 2024
Summary: Reverting PR facebookincubator#10884 due to it breaking PyVelox builds and Fuzzer . Fixes issue : facebookincubator#10963 Original commit changeset: dec13d672129 Original Phabricator Diff: D62373662 Reviewed By: amitkdutta Differential Revision: D62477240
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this issue
Sep 11, 2024
…or#10965) Summary: Pull Request resolved: facebookincubator#10965 Reverting PR facebookincubator#10884 due to it breaking PyVelox builds and Fuzzer . Fixes issue : facebookincubator#10963 Original commit changeset: dec13d672129 Original Phabricator Diff: D62373662 Reviewed By: xiaoxmeng, amitkdutta, kagamiori Differential Revision: D62477240
facebook-github-bot
pushed a commit
that referenced
this issue
Sep 11, 2024
Summary: Pull Request resolved: #10965 Reverting PR #10884 due to it breaking PyVelox builds and Fuzzer . Fixes issue : #10963 Original commit changeset: dec13d672129 Original Phabricator Diff: D62373662 Reviewed By: xiaoxmeng, amitkdutta, kagamiori Differential Revision: D62477240 fbshipit-source-id: a98174e1be031864e84dd11ba8eb3475415d5a0e
Closed by #10965 |
facebook-github-bot
pushed a commit
that referenced
this issue
Sep 26, 2024
Summary: The early merged pr (38f9a1f) was reverted by #10965 due to this issue: #10963. In the original impl., a patch is expected to be applied to add `-fPIC` before building lib stemmer, but when building docker image (ghcr.io/facebookincubator/velox-dev:centos9), that patch file is not available to use due to the copied setup script outside velox repo is executed. See code: https://github.com/facebookincubator/velox/blob/7f2d7adaa1544c72129fd1c8d0766755ff354455/scripts/centos.dockerfile#L22 This pr proposes the installation of lib stemmer with the above issue fixed. Pull Request resolved: #10984 Reviewed By: DanielHunte Differential Revision: D63344087 Pulled By: Yuhta fbshipit-source-id: a1467f5392ef828efdd219d0b7f1dfe0003d00ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem description
Seems like this is due to lib stemmer not being built with position independent code ?
PyVelox builds fail with the following error :
System information
https://github.com/facebookincubator/velox/actions/runs/10800144787/job/29957468844?pr=10962
CMake log
No response
The text was updated successfully, but these errors were encountered: