Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Velox] Fix some gaps in clang format #10127

Closed

Conversation

kevinwilfong
Copy link
Contributor

Importing some recent diffs I noticed a couple gaps in our clang formatting (make format-fix).

  1. clang formatting does not run on renamed files, renamed files may also have code changes so these should be checked
    as well
  2. we do not check for new lines at the end of files

The latter requires using clang-format 16 or above.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2024
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 572e42b
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66679f75e868c20008945461

@kevinwilfong kevinwilfong force-pushed the clang-newline branch 4 times, most recently from 05befcf to dcbf7bf Compare June 11, 2024 00:49
@kevinwilfong kevinwilfong marked this pull request as draft June 11, 2024 00:49
@kevinwilfong
Copy link
Contributor Author

Looks like we need Centos 9 to get clang-format >= 16

I'll wait for #9903

Copy link

stale bot commented Sep 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

@stale stale bot added the stale label Sep 9, 2024
@stale stale bot closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants