Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ${{ github.workspace }} variable in CI #10437

Closed
wants to merge 4 commits into from
Closed

Use ${{ github.workspace }} variable in CI #10437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3674658
Use GITHUB_WORKSPACE variable in CI
bdice Jul 9, 2024
6da1d12
Use ${{ github.workspace }} instead.
bdice Jul 24, 2024
28dfc56
Revert "Use ${{ github.workspace }} instead."
bdice Jul 24, 2024
33849fa
Use ${GITHUB_WORKSPACE} in git safe commands.
bdice Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-metrics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
- name: Fix git permissions
# Usually actions/checkout does this but as we run in a container
# it doesn't work
run: git config --global --add safe.directory /__w/velox/velox
run: git config --global --add safe.directory ${GITHUB_WORKSPACE}

- name: Make ${{ matrix.type }} Build
env:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/experimental.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,12 @@ jobs:
name: join
path: velox/_build/debug/velox/exec/tests/velox_join_fuzzer_test


presto-java-aggregation-fuzzer-run:
runs-on: 8-core-ubuntu
container: ghcr.io/facebookincubator/velox-dev:presto-java
timeout-minutes: 120
env:
CCACHE_DIR: "/__w/velox/velox/.ccache/"
CCACHE_DIR: "${{ github.workspace }}/.ccache/"
LINUX_DISTRO: "centos"
steps:

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/linux-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
run:
shell: bash
env:
CCACHE_DIR: "/__w/velox/velox/.ccache"
CCACHE_DIR: "${{ github.workspace }}/.ccache"
VELOX_DEPENDENCY_SOURCE: SYSTEM
Protobuf_SOURCE: BUNDLED # can be removed after #10134 is merged
simdjson_SOURCE: BUNDLED
Expand All @@ -70,7 +70,7 @@ jobs:
- name: Fix git permissions
# Usually actions/checkout does this but as we run in a container
# it doesn't work
run: git config --global --add safe.directory /__w/velox/velox
run: git config --global --add safe.directory ${GITHUB_WORKSPACE}

- name: Install Dependencies
run: |
Expand Down Expand Up @@ -124,7 +124,7 @@ jobs:
# Some of the adapters dependencies are in the 'adapters' conda env
shell: mamba run --no-capture-output -n adapters /usr/bin/bash -e {0}
env:
LIBHDFS3_CONF: "/__w/velox/velox/scripts/hdfs-client.xml"
LIBHDFS3_CONF: "${{ github.workspace }}/scripts/hdfs-client.xml"
working-directory: _build/release
run: |
ctest -j 8 --output-on-failure --no-tests=error
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/preliminary_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
fail-fast: false
matrix:
config:
- { name: "License Header",
- { name: "License Header",
command: "header-fix",
message: "Found missing License Header(s)",
}
Expand All @@ -50,9 +50,9 @@ jobs:
- name: Fix git permissions
# Usually actions/checkout does this but as we run in a container
# it doesn't work
run: git config --global --add safe.directory /__w/velox/velox
run: git config --global --add safe.directory ${GITHUB_WORKSPACE}

- name: Check ${{ matrix.config.name }}
- name: Check ${{ matrix.config.name }}
run: |
make ${{ matrix.config.command }}

Expand Down
15 changes: 7 additions & 8 deletions .github/workflows/scheduled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
container: ghcr.io/facebookincubator/velox-dev:centos9
timeout-minutes: 120
env:
CCACHE_DIR: "/__w/velox/velox/.ccache"
CCACHE_DIR: "${{ github.workspace }}/.ccache"
LINUX_DISTRO: "ubuntu"
MAKEFLAGS: "NUM_THREADS=${{ inputs.numThreads || 16 }} MAX_HIGH_MEM_JOBS=${{ inputs.maxHighMemJobs || 8 }} MAX_LINK_JOBS=${{ inputs.maxLinkJobs || 4 }}"

Expand Down Expand Up @@ -143,8 +143,8 @@ jobs:
# Usually actions/checkout does this but as we run in a container
# it doesn't work
run: |
git config --global --add safe.directory /__w/velox/velox/velox
git config --global --add safe.directory /__w/velox/velox/velox_main
git config --global --add safe.directory ${GITHUB_WORKSPACE}/velox
git config --global --add safe.directory ${GITHUB_WORKSPACE}/velox_main

- name: Ensure Stash Dirs Exists
working-directory: ${{ github.workspace }}
Expand Down Expand Up @@ -703,7 +703,7 @@ jobs:
- name: Fix git permissions
# Usually actions/checkout does this but as we run in a container
# it doesn't work
run: git config --global --add safe.directory /__w/velox/velox/velox
run: git config --global --add safe.directory ${GITHUB_WORKSPACE}/velox


- name: "Run Aggregate Fuzzer"
Expand Down Expand Up @@ -767,7 +767,7 @@ jobs:
- name: Fix git permissions
# Usually actions/checkout does this but as we run in a container
# it doesn't work
run: git config --global --add safe.directory /__w/velox/velox/velox
run: git config --global --add safe.directory ${GITHUB_WORKSPACE}/velox

- name: Download Signatures
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -864,7 +864,7 @@ jobs:
- name: Fix git permissions
# Usually actions/checkout does this but as we run in a container
# it doesn't work
run: git config --global --add safe.directory /__w/velox/velox/velox
run: git config --global --add safe.directory ${GITHUB_WORKSPACE}/velox


- name: "Run Window Fuzzer"
Expand Down Expand Up @@ -926,8 +926,7 @@ jobs:
- name: Fix git permissions
# Usually actions/checkout does this but as we run in a container
# it doesn't work
run: git config --global --add safe.directory /__w/velox/velox/velox

run: git config --global --add safe.directory ${GITHUB_WORKSPACE}/velox

- name: "Run Writer Fuzzer"
run: |
Expand Down
Loading