Timezone conversions based on seconds #10563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Timezone conversions were done based on a timepoint<milliseconds>, which is unecessary, adds possibility for overflow, and requires us to floor it after the conversion. Simplifying the code and adding some more tests. Now, only exporting a time_point<millisecond> may overflow, but not exporting to time_point<second> which is what is needed for timezone conversions. Reviewed By: mbasmanova Differential Revision: D60189530
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D60189530 |
kagamiori
approved these changes
Jul 25, 2024
|
This pull request has been merged in eceddff. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Timezone conversions were done based on a timepoint,
which is unecessary, adds possibility for overflow, and requires us to floor it
after the conversion. Simplifying the code and adding some more tests.
Now, only exporting a time_point may overflow, but not exporting
to time_point which is what is needed for timezone conversions.
Part of #10101
Reviewed By: mbasmanova
Differential Revision: D60189530