Refactor internal time zone database #10572
Conversation
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60211961 |
✅ Deploy Preview for meta-velox canceled.
|
| extern const std::vector<std::pair<int16_t, std::string>>& getTimeZoneEntries(); | ||
|
|
||
| // TODO: The string will be moved to TimeZone in the next PR. | ||
| using TTimeZoneDatabase = std::vector<std::unique_ptr<std::string>>; |
There was a problem hiding this comment.
Why do you use unique_pr<string>?
There was a problem hiding this comment.
In the next PR I'll move this to unique_ptr<TimeZone>, but I worried it would make this PR too large to review, so this seemed like a good compromise. For now unique_ptr<string> because I need to represent that some entries are empty (nullptr).
|
This pull request was exported from Phabricator. Differential Revision: D60211961 |
Summary: Pull Request resolved: facebookincubator#10572 Refactoring the internal time zone database to prepare for the next PR. Moving map from ID to string to vector, to remove the map access for the hot path. Also re-organizing the code to allow them to reference each other. Reviewed By: mbasmanova Differential Revision: D60211961
pedroerp
force-pushed
the
export-D60211961
branch
from
7028657 to
c6aeacd
Compare
Summary: Pull Request resolved: facebookincubator#10572 Refactoring the internal time zone database to prepare for the next PR. Moving map from ID to string to vector, to remove the map access for the hot path. Also re-organizing the code to allow them to reference each other. Reviewed By: mbasmanova Differential Revision: D60211961
|
This pull request was exported from Phabricator. Differential Revision: D60211961 |
pedroerp
force-pushed
the
export-D60211961
branch
from
c6aeacd to
b57bc0f
Compare
|
This pull request has been merged in e3e791a. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Summary:
Refactoring the internal time zone database to prepare for the next
PR. Moving map from ID to string to vector, to remove the map access
for the hot path. Also re-organizing the code to allow them to
reference each other.
Part of #10101
Differential Revision: D60211961