Add tests for array_min/array_max with TimestampWithTimezone #11141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D63708110 |
|
This pull request was exported from Phabricator. Differential Revision: D63708110 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 1, 2024
…kincubator#11141) Summary: Pull Request resolved: facebookincubator#11141 With facebookincubator#11136 array_min and array_max just work with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D63708110
kevinwilfong
force-pushed
the
export-D63708110
branch
from
f4c8012 to
6ed26c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63708110 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 1, 2024
…kincubator#11141) Summary: Pull Request resolved: facebookincubator#11141 With facebookincubator#11136 array_min and array_max just work with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D63708110
kevinwilfong
force-pushed
the
export-D63708110
branch
from
6ed26c6 to
017023f
Compare
There was a problem hiding this comment.
Looks good % @kgpai 's comments that he added internally. Will defer approval to him
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 3, 2024
…kincubator#11141) Summary: With facebookincubator#11136 array_min and array_max just work with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D63708110
…kincubator#11141) Summary: With facebookincubator#11136 array_min and array_max just work with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D63708110
kevinwilfong
force-pushed
the
export-D63708110
branch
from
017023f to
d4d926c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63708110 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 7, 2024
…kincubator#11141) Summary: With facebookincubator#11136 array_min and array_max just work with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D63708110
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 7, 2024
…kincubator#11141) Summary: With facebookincubator#11136 array_min and array_max just work with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D63708110
kgpai
approved these changes
Oct 7, 2024
|
This pull request has been merged in 2d118aa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With #11136 array_min and array_max
just work with TimestampWithTimezone.
Adding unit tests to verify this and ensure it doesn't break in the future.
Differential Revision: D63708110