Throw when null row is passed to multimap_from_entries #11166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63870933 |
✅ Deploy Preview for meta-velox canceled.
|
DanielHunte
force-pushed
the
export-D63870933
branch
from
b357624 to
6bda56d
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Oct 7, 2024
…ator#11166) Summary: Currently velox completely ignores null row entries in the input array whereas Presto throws when one is present. The change makes velox behave like Presto. Differential Revision: D63870933
|
This pull request was exported from Phabricator. Differential Revision: D63870933 |
kevinwilfong
approved these changes
Oct 7, 2024
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Oct 7, 2024
…ator#11166) Summary: Currently velox completely ignores null row entries in the input array whereas Presto throws when one is present. The change makes velox behave like Presto. Reviewed By: kevinwilfong Differential Revision: D63870933
DanielHunte
force-pushed
the
export-D63870933
branch
from
6bda56d to
a87093b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63870933 |
…ator#11166) Summary: Currently velox completely ignores null row entries in the input array whereas Presto throws when one is present. The change makes velox behave like Presto. Reviewed By: kevinwilfong Differential Revision: D63870933
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Oct 7, 2024
…ator#11166) Summary: Currently velox completely ignores null row entries in the input array whereas Presto throws when one is present. The change makes velox behave like Presto. Reviewed By: kevinwilfong Differential Revision: D63870933
DanielHunte
force-pushed
the
export-D63870933
branch
2 times, most recently
from
1fb1b53 to
614458f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63870933 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D63870933 |
|
This pull request has been merged in 88888e7. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…ator#11166) Summary: Pull Request resolved: facebookincubator#11166 Currently velox completely ignores null row entries in the input array whereas Presto throws when one is present. The change makes velox behave like Presto. Reviewed By: kevinwilfong Differential Revision: D63870933 fbshipit-source-id: 275500e375886eb8acbb72f57dc884c40590d4c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently velox completely ignores null row entries in the input array whereas Presto throws when one is present. The change makes velox behave like Presto.
Differential Revision: D63870933