Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add partitioned output trace replayer #11175

Closed
wants to merge 1 commit into from
Closed

Add partitioned output trace replayer #11175

wants to merge 1 commit into from

Conversation

tanjialiang
Copy link
Contributor

@tanjialiang tanjialiang commented Oct 6, 2024 •
edited by duanmeng
Loading

Add partitioned output trace replayer to facilitate debugging for
partitioned output operator with complex input.

part of #9668

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2024
@tanjialiang tanjialiang changed the title Add partitioned output trace replayer [WIP] Add partitioned output trace replayer Oct 6, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 6, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 65f40c7
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6706df6a3502a000083c6af7

@facebook-github-bot
Copy link
Contributor

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tanjialiang tanjialiang force-pushed the po_trace branch 2 times, most recently from fd1cbd7 to be72382 Compare October 7, 2024 02:41
@tanjialiang tanjialiang marked this pull request as ready for review October 7, 2024 02:41
@tanjialiang tanjialiang changed the title [WIP] Add partitioned output trace replayer Add partitioned output trace replayer Oct 7, 2024
@tanjialiang tanjialiang requested a review from duanmeng October 7, 2024 02:42
@facebook-github-bot
Copy link
Contributor

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

duanmeng
duanmeng approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@duanmeng duanmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjialiang LGTM % some nits.

velox/tool/trace/tests/CMakeLists.txt Outdated Show resolved Hide resolved
velox/tool/trace/PartitionedOutputReplayer.cpp Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

xiaoxmeng
xiaoxmeng reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjialiang overall looks good % minors. Thanks for the code cleanup!

velox/tool/trace/PartitionedOutputReplayer.h Show resolved Hide resolved
velox/tool/trace/PartitionedOutputReplayer.h Outdated Show resolved Hide resolved
velox/tool/trace/PartitionedOutputReplayer.h Outdated Show resolved Hide resolved
velox/tool/trace/PartitionedOutputReplayer.cpp Show resolved Hide resolved
velox/tool/trace/PartitionedOutputReplayer.cpp Show resolved Hide resolved
velox/tool/trace/tests/PartitionedOutputReplayerTest.cpp Show resolved Hide resolved
assignUser
assignUser reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes look fine, just fix formating please: https://github.com/facebookincubator/velox/actions/runs/11246411426?pr=11175

@facebook-github-bot
Copy link
Contributor

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

xiaoxmeng
xiaoxmeng reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjialiang thanks for the update % minors.

velox/tool/trace/QueryReplayer.cpp Outdated Show resolved Hide resolved
velox/tool/trace/QueryReplayer.cpp Outdated Show resolved Hide resolved
velox/tool/trace/QueryReplayer.cpp Outdated Show resolved Hide resolved
velox/tool/trace/QueryReplayer.cpp Outdated Show resolved Hide resolved
velox/tool/trace/QueryReplayer.cpp Outdated Show resolved Hide resolved
velox/tool/trace/PartitionedOutputReplayer.h Outdated Show resolved Hide resolved
velox/tool/trace/PartitionedOutputReplayer.h Show resolved Hide resolved
velox/tool/trace/PartitionedOutputReplayer.cpp Outdated Show resolved Hide resolved
velox/tool/trace/PartitionedOutputReplayer.cpp Show resolved Hide resolved
velox/tool/trace/tests/PartitionedOutputReplayerTest.cpp Outdated Show resolved Hide resolved
@tanjialiang tanjialiang force-pushed the po_trace branch 2 times, most recently from 920651d to 93324dc Compare October 9, 2024 16:47
@facebook-github-bot
Copy link
Contributor

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

xiaoxmeng
xiaoxmeng approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjialiang thanks for the update!

@facebook-github-bot
Copy link
Contributor

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tanjialiang @facebook-github-bot
Add partitioned output trace replayer (facebookincubator#11175)
65f40c7 
Summary:
Add partitioned output trace replayer to facilitate debugging for
partitioned output operator with complex input.

part of facebookincubator#9668


Reviewed By: xiaoxmeng

Differential Revision: D63959956

Pulled By: tanjialiang
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63959956

@facebook-github-bot
Copy link
Contributor

@tanjialiang merged this pull request in 6ddb65f.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 6ddb65f3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser left review comments

@xiaoxmeng xiaoxmeng xiaoxmeng approved these changes

@duanmeng duanmeng duanmeng approved these changes

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tanjialiang @facebook-github-bot @duanmeng @assignUser @xiaoxmeng