add opaque type support to vector fuzzer #11189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63998462 |
✅ Deploy Preview for meta-velox canceled.
|
kunigami
force-pushed
the
export-D63998462
branch
from
bbf0d30 to
36dc40b
Compare
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Oct 8, 2024
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Differential Revision: D63998462
|
This pull request was exported from Phabricator. Differential Revision: D63998462 |
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Oct 14, 2024
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Differential Revision: D63998462
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Oct 15, 2024
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Differential Revision: D63998462
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Oct 15, 2024
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Differential Revision: D63998462
kunigami
force-pushed
the
export-D63998462
branch
from
36dc40b to
ea06dbd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63998462 |
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Oct 15, 2024
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Differential Revision: D63998462
kunigami
force-pushed
the
export-D63998462
branch
from
ea06dbd to
64e574f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63998462 |
| VectorPtr VectorFuzzer::fuzzFlatOpaque( | ||
| const TypePtr& type, | ||
| vector_size_t size) { | ||
| auto vector = BaseVector::create(type, size, pool_); |
There was a problem hiding this comment.
nit: add a VELOX_CHECK to ensure the type is indeed opaque
velox/vector/fuzzer/VectorFuzzer.cpp
Outdated
|
|
||
| auto& opaqueType = type->asOpaque(); | ||
| auto flatVector = vector->as<TFlat>(); | ||
| auto& opaqueTypeGenerator = opaqueTypeGenerators_[opaqueType.typeIndex()]; |
There was a problem hiding this comment.
nit: should we check first if a generator exists and return an error if it doesnt?
velox/vector/fuzzer/VectorFuzzer.cpp
Outdated
Comment on lines
646
to
657
| for (size_t i = 0; i < vector->size(); ++i) { | ||
| flatVector->set(i, opaqueTypeGenerator(rng_)); | ||
| } | ||
|
|
||
| for (size_t i = 0; i < vector->size(); ++i) { | ||
| if (coinToss(opts_.nullRatio)) { | ||
| flatVector->setNull(i, true); | ||
| } | ||
| } |
There was a problem hiding this comment.
should we merge these and skip generation if a row is set to null?
| @@ -374,6 +386,11 @@ class VectorFuzzer { | |||
| // function. C++ does not guarantee the order in which arguments are | |||
| // evaluated, which can lead to inconsistent results across platforms. | |||
| FuzzerGenerator rng_; | |||
|
|
|||
| std::unordered_map< | |||
There was a problem hiding this comment.
nit: can you add a comment about what it contains and how its populated?
| private: | ||
| // Generates a flat vector for primitive types. | ||
| VectorPtr fuzzFlatPrimitive(const TypePtr& type, vector_size_t size); | ||
|
|
||
| // Generates a flat vector for opaque types. |
There was a problem hiding this comment.
nit: after you add the checks I mentioned earlier, can you also update the comment to mention that it can throw for those cases
kunigami
force-pushed
the
export-D63998462
branch
from
64e574f to
3269e83
Compare
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Oct 16, 2024
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Differential Revision: D63998462
|
This pull request was exported from Phabricator. Differential Revision: D63998462 |
kagamiori
reviewed
Oct 16, 2024
| VectorFuzzer::Options opts; | ||
| opts.nullRatio = 0.5; | ||
| VectorFuzzer fuzzer(opts, pool()); | ||
| fuzzer.registerOpaqueTypeGenerator<Foo>([](FuzzerGenerator& rng) { |
There was a problem hiding this comment.
Could you register two OpaqueTypeGenerators for Foo and Bar to ensure the correct one can be retrieved?
| VectorFuzzer::Options opts; | ||
| opts.nullRatio = 0.5; | ||
| VectorFuzzer fuzzer(opts, pool()); | ||
| fuzzer.registerOpaqueTypeGenerator<Foo>([](FuzzerGenerator& rng) { |
kunigami
force-pushed
the
export-D63998462
branch
from
3269e83 to
f80ffcb
Compare
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Oct 29, 2024
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Differential Revision: D63998462
|
This pull request was exported from Phabricator. Differential Revision: D63998462 |
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Oct 29, 2024
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Differential Revision: D63998462
kunigami
force-pushed
the
export-D63998462
branch
from
f80ffcb to
03a0cfe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63998462 |
kagamiori
approved these changes
Oct 29, 2024
Comment on lines
232
to
234
| ASSERT_TRUE( | ||
| vector->encoding() == VectorEncoding::Simple::DICTIONARY || | ||
| vector->encoding() == VectorEncoding::Simple::FLAT); |
There was a problem hiding this comment.
There is a chance of fuzzer.fuzz() generating a constant vector too.
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Reviewed By: kagamiori Differential Revision: D63998462
kunigami
force-pushed
the
export-D63998462
branch
from
03a0cfe to
0e2d1a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63998462 |
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Oct 29, 2024
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Reviewed By: kagamiori Differential Revision: D63998462
kunigami
pushed a commit
to kunigami/velox
that referenced
this pull request
Oct 29, 2024
Summary: In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Reviewed By: kagamiori Differential Revision: D63998462
|
This pull request has been merged in 48f6b8d. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebookincubator#11189 In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them. The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so. Reviewed By: kagamiori Differential Revision: D63998462 fbshipit-source-id: c3f18ae6d660cf105f7b13a9fce842f8ceeec0c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In preparation for supporting Opaque types in Presto page serialization, I'd like to add support to fuzz testing to them.
The idea is that each custom type will have to provide its own randomizing function, since it's otherwise impossible for the framework to do so.
Differential Revision: D63998462