Move Aggregation Function Data Specs into the Query Runners #11192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64011761 |
✅ Deploy Preview for meta-velox canceled.
|
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 8, 2024
…incubator#11192) Summary: Aggregation Function Data Specs declare when we don't want to generate NaN/Infinity for the arguments to a particular aggregate. Today these are hard coded in the AggregationFuzzer itself, but whether or not we support NaN/Infinity in fuzzing an aggregate function is more tightly tied to what we are comparing against (in what cases it's compatible with Velox) which Fuzzer we're running (as evidenced by the fact the Presto and Spark Aggregation Fuzzers are using the same lists currently). We are seeing cases where fuzzing with the Presto Query Runner is succeeding while fuzzing with the DuckDB Query Runner is failing. To fix this I've moved the Aggregation Function Data Specs map into the Query Runner, so that we can specify per Query Runner in what aggregation functions we don't want to produce Nan/Infinity for. Differential Revision: D64011761
kevinwilfong
force-pushed
the
export-D64011761
branch
from
51ed855 to
bb6153b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64011761 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 8, 2024
…incubator#11192) Summary: Aggregation Function Data Specs declare when we don't want to generate NaN/Infinity for the arguments to a particular aggregate. Today these are hard coded in the AggregationFuzzer itself, but whether or not we support NaN/Infinity in fuzzing an aggregate function is more tightly tied to what we are comparing against (in what cases it's compatible with Velox) which Fuzzer we're running (as evidenced by the fact the Presto and Spark Aggregation Fuzzers are using the same lists currently). We are seeing cases where fuzzing with the Presto Query Runner is succeeding while fuzzing with the DuckDB Query Runner is failing. To fix this I've moved the Aggregation Function Data Specs map into the Query Runner, so that we can specify per Query Runner in what aggregation functions we don't want to produce Nan/Infinity for. Differential Revision: D64011761
kevinwilfong
force-pushed
the
export-D64011761
branch
from
bb6153b to
0759222
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64011761 |
…incubator#11192) Summary: Aggregation Function Data Specs declare when we don't want to generate NaN/Infinity for the arguments to a particular aggregate. Today these are hard coded in the AggregationFuzzer itself, but whether or not we support NaN/Infinity in fuzzing an aggregate function is more tightly tied to what we are comparing against (in what cases it's compatible with Velox) which Fuzzer we're running (as evidenced by the fact the Presto and Spark Aggregation Fuzzers are using the same lists currently). We are seeing cases where fuzzing with the Presto Query Runner is succeeding while fuzzing with the DuckDB Query Runner is failing. To fix this I've moved the Aggregation Function Data Specs map into the Query Runner, so that we can specify per Query Runner in what aggregation functions we don't want to produce Nan/Infinity for. Reviewed By: kewang1024 Differential Revision: D64011761
kevinwilfong
force-pushed
the
export-D64011761
branch
from
0759222 to
d1bbe54
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64011761 |
kewang1024
approved these changes
Oct 10, 2024
|
This pull request has been merged in 5e4b35a. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Aggregation Function Data Specs declare when we don't want to generate NaN/Infinity for the arguments to a particular aggregate.
Today these are hard coded in the AggregationFuzzer itself, but whether or not we
support NaN/Infinity in fuzzing an aggregate function is more tightly tied to what we
are comparing against (in what cases it's compatible with Velox) which Fuzzer we're
running (as evidenced by the fact the Presto and Spark Aggregation Fuzzers are using
the same lists currently). We are seeing cases where fuzzing with the Presto Query
Runner is succeeding while fuzzing with the DuckDB Query Runner is failing.
To fix this I've moved the Aggregation Function Data Specs map into the Query
Runner, so that we can specify per Query Runner in what aggregation functions we
don't want to produce Nan/Infinity for.
Differential Revision: D64011761