Fix data race in cache eviction path #11193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The cache entry init code path (thread) logs an error message with cache entry size when allocation fails. This happens after it releases the cache entry which could be race with cache eviction code path which clears to zero. The fix is to print out the allocated pages instead of bytes in cache error message to prevent. Differential Revision: D64014938
|
This pull request was exported from Phabricator. Differential Revision: D64014938 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request has been merged in 640592d. |
|
Conbench analyzed the 1 benchmark run on commit There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The cache entry init code path (thread) logs an error message with cache entry size when allocation fails.
This happens after it releases the cache entry which could be race with cache eviction code path which clears
to zero. The fix is to print out the allocated pages instead of bytes in cache error message to prevent.
Differential Revision: D64014938