Fix format_datetime to used linked TimeZone names #11337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D64870014 |
…or#11283) Summary: Pull Request resolved: facebookincubator#11283 The format_datetime currently outptus the time zone id if for 3 or fewer 'z' characters in the format string. However, the JODA library, which this is based on, does this for 3 or more 'Z' characters. https://www.joda.org/joda-time/apidocs/org/joda/time/format/DateTimeFormat.html This diff fixes this, as well as adds support for a single 'Z' (which outputs the same thing as 'ZZ' just without the colon). So 'Z' is fully supported for any number of characters. Differential Revision: D64500193
|
This pull request was exported from Phabricator. Differential Revision: D64870014 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 29, 2024
…11337) Summary: Pull Request resolved: facebookincubator#11337 JODA has this concept of linked Time Zones where given a particular time zone ID, it will write out a different time zone ID when formatting a timestamp as a string (I suspect this is for historical reasons). More information is available about this here https://github.com/JodaOrg/global-tz This diff adds a script to parse the file JODA uses to get these links and turn it into a static map. I've done this for the file in the version of JODA Presto Java currently uses (there have been significant updates in more recent versions). Note that the file guarantees there are no transitive links so we don't need to handle that case. I then updated the format_datetime UDF to use this mapping for the ZZZ (or more) pattern. It will use the linked time zone ID in place of the time zone ID if one is available. This is also fixes casting TimestampWithTimeZone to Varchar which uses the same code path. Reviewed By: xiaoxmeng Differential Revision: D64870014
kevinwilfong
force-pushed
the
export-D64870014
branch
from
cf0e9ae to
bdeba8a
Compare
kevinwilfong
requested review from
assignUser and
majetideepak
as code owners
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 29, 2024
…11337) Summary: Pull Request resolved: facebookincubator#11337 JODA has this concept of linked Time Zones where given a particular time zone ID, it will write out a different time zone ID when formatting a timestamp as a string (I suspect this is for historical reasons). More information is available about this here https://github.com/JodaOrg/global-tz This diff adds a script to parse the file JODA uses to get these links and turn it into a static map. I've done this for the file in the version of JODA Presto Java currently uses (there have been significant updates in more recent versions). Note that the file guarantees there are no transitive links so we don't need to handle that case. I then updated the format_datetime UDF to use this mapping for the ZZZ (or more) pattern. It will use the linked time zone ID in place of the time zone ID if one is available. This is also fixes casting TimestampWithTimeZone to Varchar which uses the same code path. Reviewed By: xiaoxmeng Differential Revision: D64870014
|
This pull request was exported from Phabricator. Differential Revision: D64870014 |
kevinwilfong
force-pushed
the
export-D64870014
branch
from
bdeba8a to
8bbd3c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64870014 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 29, 2024
…11337) Summary: Pull Request resolved: facebookincubator#11337 JODA has this concept of linked Time Zones where given a particular time zone ID, it will write out a different time zone ID when formatting a timestamp as a string (I suspect this is for historical reasons). More information is available about this here https://github.com/JodaOrg/global-tz This diff adds a script to parse the file JODA uses to get these links and turn it into a static map. I've done this for the file in the version of JODA Presto Java currently uses (there have been significant updates in more recent versions). Note that the file guarantees there are no transitive links so we don't need to handle that case. I then updated the format_datetime UDF to use this mapping for the ZZZ (or more) pattern. It will use the linked time zone ID in place of the time zone ID if one is available. This is also fixes casting TimestampWithTimeZone to Varchar which uses the same code path. Reviewed By: xiaoxmeng Differential Revision: D64870014
kevinwilfong
force-pushed
the
export-D64870014
branch
from
8bbd3c3 to
cb7f4ab
Compare
…11337) Summary: Pull Request resolved: facebookincubator#11337 JODA has this concept of linked Time Zones where given a particular time zone ID, it will write out a different time zone ID when formatting a timestamp as a string (I suspect this is for historical reasons). More information is available about this here https://github.com/JodaOrg/global-tz This diff adds a script to parse the file JODA uses to get these links and turn it into a static map. I've done this for the file in the version of JODA Presto Java currently uses (there have been significant updates in more recent versions). Note that the file guarantees there are no transitive links so we don't need to handle that case. I then updated the format_datetime UDF to use this mapping for the ZZZ (or more) pattern. It will use the linked time zone ID in place of the time zone ID if one is available. This is also fixes casting TimestampWithTimeZone to Varchar which uses the same code path. Reviewed By: xiaoxmeng Differential Revision: D64870014
kevinwilfong
force-pushed
the
export-D64870014
branch
from
cb7f4ab to
547c86a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64870014 |
|
This pull request has been merged in b1834bd. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
JODA has this concept of linked Time Zones where given a particular time zone ID, it
will write out a different time zone ID when formatting a timestamp as a string (I
suspect this is for historical reasons).
More information is available about this here https://github.com/JodaOrg/global-tz
This diff adds a script to parse the file JODA uses to get these links and turn it into a
static map. I've done this for the file in the version of JODA Presto Java currently uses
(there have been significant updates in more recent versions). Note that the file
guarantees there are no transitive links so we don't need to handle that case.
I then updated the format_datetime UDF to use this mapping for the ZZZ (or more)
pattern. It will use the linked time zone ID in place of the time zone ID if one is
available.
This is also fixes casting TimestampWithTimeZone to Varchar which uses the same
code path.
Differential Revision: D64870014