Fix Presto's date_diff UDF with TimestampAndTimeZone and DST #11380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D65165953 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 29, 2024
…kincubator#11380) Summary: Presto Java's date_diff UDF respects DST for units greater than or equal to a day, but for units less than a day computes the diff on the system time (GMT). This means for units less than a day date_diff with TimestampWithTimeZone cannot compute the difference of the local times. It needs to use system time to be consistent. Note that the for units greater than or equal to a day, this does not apply, and we should continue to use the local time to compute the difference. This is analogous to the change made to date_add in facebookincubator#11353 Differential Revision: D65165953
kevinwilfong
force-pushed
the
export-D65165953
branch
from
4fab016 to
9240144
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65165953 |
added 2 commits
October 30, 2024 10:17
…incubator#11353) Summary: Presto Java's date_add UDF treats the day the clocks move forward as a 23 hour day, and the day the clocks move back as a 25 hour day. This means for units greater than or equal to a day date_add with TimestampWithTimeZone cannot simply use the addition on GMT. It needs to compute the addition based on the local time to handle these. Note that the for units less than a day, this does not apply, and will produce incorrect results if we compute it using local time. Reviewed By: xiaoxmeng Differential Revision: D64982873
…kincubator#11380) Summary: Presto Java's date_diff UDF respects DST for units greater than or equal to a day, but for units less than a day computes the diff on the system time (GMT). This means for units less than a day date_diff with TimestampWithTimeZone cannot compute the difference of the local times. It needs to use system time to be consistent. Note that the for units greater than or equal to a day, this does not apply, and we should continue to use the local time to compute the difference. This is analogous to the change made to date_add in facebookincubator#11353 Reviewed By: xiaoxmeng Differential Revision: D65165953
kevinwilfong
force-pushed
the
export-D65165953
branch
from
9240144 to
dad4d83
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65165953 |
xiaoxmeng
approved these changes
Oct 30, 2024
|
This pull request has been merged in 7377bc8. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Presto Java's date_diff UDF respects DST for units greater than or equal to a day, but
for units less than a day computes the diff on the system time (GMT).
This means for units less than a day date_diff with TimestampWithTimeZone cannot
compute the difference of the local times. It needs to use system time to be
consistent.
Note that the for units greater than or equal to a day, this does not apply, and we
should continue to use the local time to compute the difference.
This is analogous to the change made to date_add in
#11353
Differential Revision: D65165953