feat: Add runner for local distributed execution #11507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D65779177 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Nov 12, 2024
…okincubator#11507) Summary: Reintroducing Orri's change based on PR: facebookincubator#11475 This diff attempts to fix the CMAKE errors of the first PR. Original commit changeset: 6cf86c88d7c8 Original Phabricator Diff: D65631783 Reviewed By: xiaoxmeng Differential Revision: D65779177
kgpai
force-pushed
the
export-D65779177
branch
from
dd92d23 to
7b7680f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65779177 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Nov 12, 2024
…okincubator#11507) Summary: Reintroducing Orri's change based on PR: facebookincubator#11475 This diff attempts to fix the CMAKE errors of the first PR. Original commit changeset: 6cf86c88d7c8 Original Phabricator Diff: D65631783 Reviewed By: xiaoxmeng Differential Revision: D65779177
kgpai
force-pushed
the
export-D65779177
branch
from
7b7680f to
93f130b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65779177 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Nov 12, 2024
…okincubator#11507) Summary: Reintroducing Orri's change based on PR: facebookincubator#11475 This diff attempts to fix the CMAKE errors of the first PR. Original commit changeset: 6cf86c88d7c8 Original Phabricator Diff: D65631783 Reviewed By: xiaoxmeng Differential Revision: D65779177
kgpai
force-pushed
the
export-D65779177
branch
from
93f130b to
92a538a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65779177 |
xiaoxmeng
approved these changes
Nov 12, 2024
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…okincubator#11507) Summary: Reintroducing Orri's change based on PR: facebookincubator#11475 This diff attempts to fix the CMAKE errors of the first PR. Original commit changeset: 6cf86c88d7c8 Original Phabricator Diff: D65631783 Differential Revision: D65779177 Pulled By: kgpai
kgpai
force-pushed
the
export-D65779177
branch
from
92a538a to
d611c94
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65779177 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
Summary: Reintroducing Orri's change based on PR: #11475 This diff attempts to fix the CMAKE errors of the first PR. Original commit changeset: 6cf86c88d7c8 Original Phabricator Diff: D65631783 Differential Revision: D65779177 Pulled By: kgpai fbshipit-source-id: 4e52927c05ff5210aeeec59f50bb5584e4dee2f0
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Nov 13, 2024
Summary: Backing out to unbreak OSS CI. The PR facebookincubator#11507 seems to have broken pyVelox builds. Backing out so we can investigate and fix. Original commit changeset: 4e52927c05ff Original Phabricator Diff: D65779177 Differential Revision: D65900074
majetideepak
changed the title
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
…on" (#11529) Summary: Pull Request resolved: #11529 Backing out to unbreak OSS CI. The PR #11507 seems to have broken pyVelox builds. Backing out so we can investigate and fix. Original commit changeset: 4e52927c05ff Original Phabricator Diff: D65779177 Reviewed By: xiaoxmeng Differential Revision: D65900074 fbshipit-source-id: 97be486003428caa77c118dbd4b3ae1e14d280d4
|
This pull request has been reverted by 99979c4. |
|
Superseded by #11609 |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…okincubator#11507) Summary: Reintroducing Orri's change based on PR: facebookincubator#11475 This diff attempts to fix the CMAKE errors of the first PR. Original commit changeset: 6cf86c88d7c8 Original Phabricator Diff: D65631783 Differential Revision: D65779177 Pulled By: kgpai fbshipit-source-id: 4e52927c05ff5210aeeec59f50bb5584e4dee2f0
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…on" (facebookincubator#11529) Summary: Pull Request resolved: facebookincubator#11529 Backing out to unbreak OSS CI. The PR facebookincubator#11507 seems to have broken pyVelox builds. Backing out so we can investigate and fix. Original commit changeset: 4e52927c05ff Original Phabricator Diff: D65779177 Reviewed By: xiaoxmeng Differential Revision: D65900074 fbshipit-source-id: 97be486003428caa77c118dbd4b3ae1e14d280d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reintroducing Orri's change based on PR: #11475
This diff attempts to fix the CMAKE errors of the first PR.
Original commit changeset: 6cf86c88d7c8
Original Phabricator Diff: D65631783
Reviewed By: xiaoxmeng
Differential Revision: D65779177