fix(fuzzer): Add filter parsing to toSql methods for hasJoinNode in ReferenceQueryRunners #11566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D66021799 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 18, 2024
…Runners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 18, 2024
…ferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 18, 2024
…ferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
force-pushed
the
export-D66021799
branch
from
02884d6 to
ab726a0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66021799 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 18, 2024
…ferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 18, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
force-pushed
the
export-D66021799
branch
from
ab726a0 to
57faacd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66021799 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 18, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 18, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
changed the title
DanielHunte
changed the title
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 19, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
force-pushed
the
export-D66021799
branch
from
57faacd to
f3bf3f5
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 19, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 19, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
|
This pull request was exported from Phabricator. Differential Revision: D66021799 |
kagamiori
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Hi @DanielHunte, thank you for adding support for filters in join nodes.
DanielHunte
force-pushed
the
export-D66021799
branch
from
f3bf3f5 to
0633e36
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
|
This pull request was exported from Phabricator. Differential Revision: D66021799 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
force-pushed
the
export-D66021799
branch
from
6f6f27a to
6aed178
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
|
This pull request was exported from Phabricator. Differential Revision: D66021799 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
force-pushed
the
export-D66021799
branch
from
6aed178 to
3103be3
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
|
This pull request was exported from Phabricator. Differential Revision: D66021799 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…eferenceQueryRunners (facebookincubator#11566) Summary: Pull Request resolved: facebookincubator#11566 This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799 fbshipit-source-id: 421a5d5e105bc02d6dfb4ef1fe9c0e6deec351a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods.
Differential Revision: D66021799