feat: Support API for setting a spill directory callback in task #11572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
✅ Deploy Preview for meta-velox canceled.
|
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 18, 2024
… spill directory with custom options (facebookincubator#11572) Summary: Add ability to create the parent spill direction with custom options. We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
386f2cb to
63ac69d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
changed the title
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 18, 2024
… spill directory with custom options (facebookincubator#11572) Summary: Add ability to create the parent spill direction with custom options. We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
63ac69d to
49f5938
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 18, 2024
… spill directory with custom options (facebookincubator#11572) Summary: Add ability to create the parent spill direction with custom options. We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
49f5938 to
e6beacb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
force-pushed
the
export-D65964247
branch
from
e6beacb to
1ea454f
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 19, 2024
… spill directory with custom options (facebookincubator#11572) Summary: Add ability to create the parent spill direction with custom options. We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 19, 2024
… spill directory with custom options (facebookincubator#11572) Summary: Add ability to create the parent spill direction with custom options. We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
1ea454f to
c35ed10
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 19, 2024
… spill directory with custom options (facebookincubator#11572) Summary: Add ability to create the parent spill direction with custom options. We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
c35ed10 to
c612d06
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 19, 2024
… spill directory with custom options (facebookincubator#11572) Summary: Add ability to create the parent spill direction with custom options. We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
c612d06 to
41d6adc
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 19, 2024
… spill directory with custom options (facebookincubator#11572) Summary: Add ability to create the parent spill direction with custom options. We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
41d6adc to
25c54bb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 19, 2024
… spill directory with custom options (facebookincubator#11572) Summary: Add ability to create the parent spill direction with custom options. We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 22, 2024
…ebookincubator#11572) Summary: Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
1a3f8cd to
ad0a522
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
force-pushed
the
export-D65964247
branch
from
ad0a522 to
4fcc0f3
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 22, 2024
…ebookincubator#11572) Summary: Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 22, 2024
…ebookincubator#11572) Summary: Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created We also add the ability for mkdir to decide whether or not to fail if a directory was created Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
4fcc0f3 to
bc3e323
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 22, 2024
…ebookincubator#11572) Summary: Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created We also add the ability for mkdir to decide whether or not to fail if a directory was created Reviewed By: xiaoxmeng Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
bc3e323 to
89db38e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 22, 2024
…ebookincubator#11572) Summary: Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created We also add the ability for mkdir to decide whether or not to fail if a directory was created Reviewed By: xiaoxmeng Differential Revision: D65964247
xiaoxmeng
approved these changes
Nov 25, 2024
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 25, 2024
…ebookincubator#11572) Summary: Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created We also add the ability for mkdir to decide whether or not to fail if a directory was created Reviewed By: xiaoxmeng Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
89db38e to
d407741
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 26, 2024
…ebookincubator#11572) Summary: Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created We also add the ability for mkdir to decide whether or not to fail if a directory was created Reviewed By: xiaoxmeng Differential Revision: D65964247
…ebookincubator#11572) Summary: Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created We also add the ability for mkdir to decide whether or not to fail if a directory was created Reviewed By: xiaoxmeng Differential Revision: D65964247
yuandagits
force-pushed
the
export-D65964247
branch
from
d407741 to
b84aba5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65964247 |
|
This pull request has been merged in f013684. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
6 tasks
TongWei1105
pushed a commit
to TongWei1105/velox
that referenced
this pull request
Dec 3, 2024
…ebookincubator#11572) Summary: Pull Request resolved: facebookincubator#11572 Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created We also add the ability for mkdir to decide whether or not to fail if a directory was created Reviewed By: xiaoxmeng Differential Revision: D65964247 fbshipit-source-id: c35f9953ba134e0ba048213adacc101fb22b1892
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…ebookincubator#11572) Summary: Pull Request resolved: facebookincubator#11572 Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created We also add the ability for mkdir to decide whether or not to fail if a directory was created Reviewed By: xiaoxmeng Differential Revision: D65964247 fbshipit-source-id: c35f9953ba134e0ba048213adacc101fb22b1892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add ability to set a spill directory callback in task. The callback will create the spill directory and return the directory created.
We also add the ability for mkdir to decide whether or not to fail if a directory was created.