Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor package namespace in HdfsFileSystem #11585

Closed
wants to merge 1 commit into from

Conversation

JkSelf
Copy link
Collaborator

@JkSelf JkSelf commented Nov 19, 2024

After merging PR #9835, Gluten encountered the following compilation error. This PR refactors the package namespace to resolve the ambiguity issue.

/mnt/DP_disk3/jk/projects/gluten/cpp/velox/memory/VeloxColumnarBatch.cc:33:5: error: reference to ‘velox’ is ambiguous
   33 |     velox::memory::MemoryPool* pool,
      |     ^~~~~
In file included from /mnt/DP_disk3/jk/projects/gluten/cpp/velox/operators/writer/VeloxParquetDataSource.h:43,
                 from /mnt/DP_disk3/jk/projects/gluten/cpp/velox/compute/VeloxRuntime.h:25,
                 from /mnt/DP_disk3/jk/projects/gluten/cpp/velox/memory/VeloxColumnarBatch.cc:18:
/mnt/DP_disk3/jk/projects/gluten/dev/../ep/build-velox/build/velox_ep/velox/connectors/hive/storage_adapters/hdfs/HdfsFileSystem.h:18:11: note: candidates are: ‘namespace velox { }’
   18 | namespace velox::filesystems::arrow::io::internal {
      |           ^~~~~
In file included from /mnt/DP_disk3/jk/projects/gluten/dev/../ep/build-velox/build/velox_ep/velox/common/base/VeloxException.h:29,
                 from /mnt/DP_disk3/jk/projects/gluten/dev/../ep/build-velox/build/velox_ep/velox/common/base/Exceptions.h:27,
                 from /mnt/DP_disk3/jk/projects/gluten/dev/../ep/build-velox/build/velox_ep/velox/common/base/BitUtil.h:19,
                 from /mnt/DP_disk3/jk/projects/gluten/dev/../ep/build-velox/build/velox_ep/velox/common/caching/AsyncDataCache.h:27,
                 from /mnt/DP_disk3/jk/projects/gluten/cpp/velox/compute/VeloxBackend.h:27,
                 from /mnt/DP_disk3/jk/projects/gluten/cpp/velox/memory/VeloxMemoryManager.h:20,
                 from /mnt/DP_disk3/jk/projects/gluten/cpp/velox/memory/VeloxColumnarBatch.h:21,
                 from /mnt/DP_disk3/jk/projects/gluten/cpp/velox/memory/VeloxColumnarBatch.cc:17:

@JkSelf JkSelf requested a review from majetideepak as a code owner November 19, 2024 08:15
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 9abbeef
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67593e9d6771b30008992e07

@JkSelf JkSelf changed the title Refactor package namespace in HdfsFileSystem fix: Refactor package namespace in HdfsFileSystem Nov 19, 2024
@majetideepak
Copy link
Collaborator

@JkSelf can you rebase with the latest master?

@JkSelf
Copy link
Collaborator Author

JkSelf commented Dec 5, 2024

@JkSelf can you rebase with the latest master?

@majetideepak Yes. Rebased to the latest master. Can you help to review again? Thanks.

@JkSelf
Copy link
Collaborator Author

JkSelf commented Dec 11, 2024

@majetideepak Can you help to review this PR again? Thanks.

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Dec 11, 2024
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in d9a6012.

majetideepak added a commit to majetideepak/velox that referenced this pull request Dec 17, 2024
facebook-github-bot pushed a commit that referenced this pull request Dec 19, 2024
Summary: Pull Request resolved: #11891

Reviewed By: gggrace14

Differential Revision: D67454649

Pulled By: pedroerp

fbshipit-source-id: 05e2ccd61e7abf6f8431c030cde190ea7cc703e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants