build: The setup-adapters.sh script fails to run on macOS #11592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
On macOS the /etc/os-release does not exist and the script throws an error when attempting to read the LINUX_DISTRIBUTION variable. The variable was moved in error not considering that macOS will not have /etc/os-release.
czentgr
force-pushed
the
cz_fix_adapters
branch
from
266798a to
0da8e67
Compare
|
@majetideepak FYI |
czentgr
changed the title
assignUser
changed the title
assignUser
approved these changes
Nov 20, 2024
assignUser
added
the
ready-to-merge
majetideepak
approved these changes
Nov 20, 2024
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori merged this pull request in 581f3fe. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…cubator#11592) Summary: On macOS the /etc/os-release file does not exist and the script throws an error when attempting to read the LINUX_DISTRIBUTION variable. The variable was moved in error not considering that macOS will not have /etc/os-release. Pull Request resolved: facebookincubator#11592 Reviewed By: kevinwilfong Differential Revision: D66252274 Pulled By: kagamiori fbshipit-source-id: b50e21d153f0ab35bb217cb850ae88b2b621b496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS the /etc/os-release file does not exist and the script throws an error when attempting to read the LINUX_DISTRIBUTION variable.
The variable was moved in error not considering that macOS will not have /etc/os-release.