fix: Disable Thread Sanitization for an E2E Test that Times Out #11596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D66195933 |
macvincent
force-pushed
the
export-D66195933
branch
from
7ca36cd to
b2219c1
Compare
macvincent
pushed a commit
to macvincent/velox
that referenced
this pull request
Nov 19, 2024
…ncubator#11596) Summary: We have an E2E test that times out: https://www.internalfb.com/intern/test/281475162253204 It reads and writes 2000 rows. We want to maintain the query shape but exclude the culprit test during TSAN runs. TSAN was recently enabled for this code path: D65836700 Differential Revision: D66195933
|
This pull request was exported from Phabricator. Differential Revision: D66195933 |
macvincent
pushed a commit
to macvincent/velox
that referenced
this pull request
Nov 19, 2024
…bookincubator#11596) Summary: We have an E2E test that times out: https://www.internalfb.com/intern/test/281475162253204 It reads and writes 2000 rows. We want to maintain the query shape but exclude the culprit test during TSAN runs. TSAN was recently enabled for this code path: D65836700 Differential Revision: D66195933
macvincent
force-pushed
the
export-D66195933
branch
from
b2219c1 to
e2c8006
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66195933 |
macvincent
changed the title
…bookincubator#11596) Summary: We have an E2E test that times out: https://www.internalfb.com/intern/test/281475162253204 It reads and writes 2000 rows. We want to maintain the query shape but exclude the culprit test during TSAN runs. TSAN was recently enabled for this code path: D65836700 Reviewed By: HuamengJiang Differential Revision: D66195933
macvincent
force-pushed
the
export-D66195933
branch
from
e2c8006 to
c627b36
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66195933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have an E2E test that times out: https://www.internalfb.com/intern/test/281475162253204
It reads and writes 2000 rows. We want to maintain the query shape but exclude the culprit test during TSAN runs. TSAN was recently enabled for this code path: D65836700
Differential Revision: D66195933