feat: Add mathematical operators for IntervalYearMonth type #11612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
There was a problem hiding this comment.
Thanks @pramodsatya.
We can use more templates in this code I feel to reduce the volume of new code. PTAL.
pramodsatya
force-pushed
the
ym_multiply
branch
from
d1bac96 to
34c093e
Compare
|
Thanks @aditi-pandit, updated the PR to use more templates and reduce the lines of new code. Could you please take another look? |
pramodsatya
force-pushed
the
ym_multiply
branch
from
34c093e to
0afc30c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for mathematical functions
plus,minus,multiply, anddividewith
IntervalYearMonthtype. The function signatures added match that of Presto,accounting for the Presto function signature changes in prestodb/presto#24089.