-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(cmake): Clean up various issues #11751
Conversation
Our supported GCC version no longer requires it fs
✅ Deploy Preview for meta-velox canceled.
|
The test is failing on main |
I have moved the wrapped proto files into velox_dwrf_common as they are never used standalone, so there is no reason to make a standalone library. |
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lazy +1
I have pulled these changes from #10732 as they are not specifically part of the shared build.
[<dependency name>]
as an indicator that a dependency is running CMake. This makes it much easier to parse the log and track issues: