refactor: Move some logic from URLFunctions.h to URIParser #11761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66832201 |
✅ Deploy Preview for meta-velox canceled.
|
yuandagits
approved these changes
Dec 6, 2024
kevinwilfong
force-pushed
the
export-D66832201
branch
from
9044c56 to
52b7cfc
Compare
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Dec 6, 2024
…ncubator#11761) Summary: There's some UDFs outside of prestosql's URL functions where I'd like to reuse some of the logic I wrote for handling URIs. Specifically: * tryConsumeIPV6Address: this is generally useful for parsing IPv6 addresses * isMultipleInvalidSequences: this is generally useful for determining how many valid subsequences make up an invalid code point from tryGetUtf8CharLength. * extractParameter: this is generally useful for extracting the parameter from a URI's query string This change moves those functions into URIParser where they can be reused. Reviewed By: kgpai, yuandagits Differential Revision: D66832201
|
This pull request was exported from Phabricator. Differential Revision: D66832201 |
added 2 commits
December 6, 2024 15:05
…ebookincubator#11782) Summary: When an IPv6 address in a URI does not end with a closing ']' and this happens at the end of the string, the parser will enter an infinite loop. The fix is to break out of the loop when we realize we're at the end of the string. tryConsumeIPV6Address is not responsible for consume the closing ']' so the caller will realize the issue when it attempts to consume it (this is already handled properly there). Differential Revision: D66904149
…ncubator#11761) Summary: There's some UDFs outside of prestosql's URL functions where I'd like to reuse some of the logic I wrote for handling URIs. Specifically: * tryConsumeIPV6Address: this is generally useful for parsing IPv6 addresses * isMultipleInvalidSequences: this is generally useful for determining how many valid subsequences make up an invalid code point from tryGetUtf8CharLength. * extractParameter: this is generally useful for extracting the parameter from a URI's query string This change moves those functions into URIParser where they can be reused. Reviewed By: kgpai, yuandagits Differential Revision: D66832201
kevinwilfong
force-pushed
the
export-D66832201
branch
from
52b7cfc to
920d11a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66832201 |
|
This pull request has been merged in 1b5d3db. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…ncubator#11761) Summary: Pull Request resolved: facebookincubator#11761 There's some UDFs outside of prestosql's URL functions where I'd like to reuse some of the logic I wrote for handling URIs. Specifically: * tryConsumeIPV6Address: this is generally useful for parsing IPv6 addresses * isMultipleInvalidSequences: this is generally useful for determining how many valid subsequences make up an invalid code point from tryGetUtf8CharLength. * extractParameter: this is generally useful for extracting the parameter from a URI's query string This change moves those functions into URIParser where they can be reused. Reviewed By: kgpai, yuandagits Differential Revision: D66832201 fbshipit-source-id: bf10289b49ac3b0abd572f2b5a985b7758f4bee4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There's some UDFs outside of prestosql's URL functions where I'd like to reuse some of the logic I
wrote for handling URIs.
Specifically:
make up an invalid code point from tryGetUtf8CharLength.
This change moves those functions into URIParser where they can be reused.
Differential Revision: D66832201