fix(hashjoin): Turn off dynamic filter push downs for null aware right semi porject join #11781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D66903863 |
DanielHunte
force-pushed
the
export-D66903863
branch
from
7d781c6 to
309783f
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Differential Revision: D66903863
|
This pull request was exported from Phabricator. Differential Revision: D66903863 |
Yuhta
approved these changes
Dec 9, 2024
DanielHunte
force-pushed
the
export-D66903863
branch
from
309783f to
014c6fe
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
|
This pull request was exported from Phabricator. Differential Revision: D66903863 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
force-pushed
the
export-D66903863
branch
from
014c6fe to
caaf0d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66903863 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 9, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 10, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 10, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
force-pushed
the
export-D66903863
branch
from
caaf0d3 to
03fb397
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66903863 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 14, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
force-pushed
the
export-D66903863
branch
from
03fb397 to
3ba886a
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
force-pushed
the
export-D66903863
branch
from
3ba886a to
7697db7
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
|
This pull request was exported from Phabricator. Differential Revision: D66903863 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 15, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
|
This pull request was exported from Phabricator. Differential Revision: D66903863 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
added 4 commits
December 15, 2024 20:41
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Reviewed By: kagamiori Differential Revision: D66021799
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
…ilters (facebookincubator#11620) Summary: The mayHaveNulls() method sometimes returns true when there are in fact no nulls. This change will make sure that a nullptr isn't passed to memcpy. Reviewed By: Yuhta Differential Revision: D66333546
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
DanielHunte
force-pushed
the
export-D66903863
branch
from
7697db7 to
c464522
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66903863 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Dec 16, 2024
…t semi porject join (facebookincubator#11781) Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null. Reviewed By: Yuhta Differential Revision: D66903863
|
This pull request has been merged in 1bf1b48. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently, when there are no matches for a null aware right semi project join but the build side has nulls, the dynamic push down filter filters out all the rows from the probe side. This causes the probe side to be considered empty and therefore sets the entire match column to falses, even in rows where the match value should be null.
Differential Revision: D66903863