refactor(parquet): Move arrow RleEncodingInternal to common

[wypb]

Follow-up PR: #11711

Summary:
Both Parquet reader and writer depend on RleEncodingInternal.
This currently resides in parquet/writer/arrow which introduces a dependency of the writer to the reader.
No functional changes.

CC: @majetideepak @pedroerp

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	bdfe824
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/675abf8e1aeaa700081f6480

[majetideepak]

@wypb Let's also change the variable names to the Velox coding convention which uses camel case. Thanks.

[wypb]

Hi @majetideepak I have made changes according to the comments. Please help me take another look when you have time. Thank you!

[majetideepak]

@wypb thanks for all the cleanup! I found some comments.

[wypb]

Hi @majetideepak Thank you for your review. I have addressed all the comments.

[majetideepak]

@wypb CI is failing. Can you take a look?

[majetideepak]

Thanks, @wypb

[majetideepak]

@wypb Is the MacOS build failure related?

[wypb]

@majetideepak The error is Linking lib/libvelox.dylib. I’m not sure if it’s related to the current PR. I’m still looking into it.

[wypb]

Hi @majetideepak I checked and found that the MacOS build failure should be related to this modification, but I haven't found the reason yet. Can you help me find the reason?

[wypb]

I introduced #include <glog/logging.h> in the Encoding.cpp file to see if it works.

[majetideepak]

Thanks @wypb. CI seems to be passing now.

[facebook-github-bot]

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[wypb]

@majetideepak Yes, the BitStreamUtilsInternal.h and RleEncodingInternal.h files in this MR deleted some arrow headers (like logging.h and ubsan.h etc.), which caused the Encoding.cpp file to lack the glog/logging.h dependency, so an error was reported during compilation.

[facebook-github-bot]

@kgpai merged this pull request in e3f7c5f.